Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix install error introduced by #9089 #9205

Merged
merged 1 commit into from
Aug 23, 2019

Conversation

pcd1193182
Copy link
Contributor

Signed-off-by: Paul Dagnelie [email protected]

Motivation and Context

When attempting to load zfs bits onto a machine that already has had zfs bits loaded onto it, an error occurs when trying to symlink the zfs-import.service file

Description

Use ln -sf to force the symlink if the file already exists

How Has This Been Tested?

building and loading the zfs repository onto a vm that already has had the zfs repository built and loaded on it.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

@pcd1193182
Copy link
Contributor Author

@c0d3z3r0 I couldn't tag you as a reviewer but if you could take a look I'd appreciate it.

@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Aug 22, 2019
Copy link
Contributor

@tonynguien tonynguien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this issue.

Copy link
Contributor

@c0d3z3r0 c0d3z3r0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm; thanks for this fix!

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Aug 22, 2019
@behlendorf behlendorf merged commit d1d1f8c into openzfs:master Aug 23, 2019
@codecov
Copy link

codecov bot commented Aug 23, 2019

Codecov Report

Merging #9205 into master will increase coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9205      +/-   ##
==========================================
+ Coverage   79.18%    79.3%   +0.11%     
==========================================
  Files         400      400              
  Lines      122002   122002              
==========================================
+ Hits        96607    96753     +146     
+ Misses      25395    25249     -146
Flag Coverage Δ
#kernel 79.83% <ø> (+0.09%) ⬆️
#user 67.34% <ø> (+0.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31b548f...d1484fb. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants