Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZTS: Use decimal values when setting tunables #9195

Merged
merged 1 commit into from
Aug 22, 2019

Conversation

behlendorf
Copy link
Contributor

Motivation and Context

Failures observed when running these test cases on a non-Linux
platform using mdb.

Description

The mdb_set_uint32 function requires that the values passed in be
decimal. This was overlooked initially because the matching Linux
function accepts both decimal and hexadecimal values.

Reviewed-by: Brian Behlendorf [email protected]
Signed-off-by: Igor Kozhukhov [email protected]
Issue #9125

How Has This Been Tested?

Tested on DilOS.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

The mdb_set_uint32 function requires that the values passed in be
decimal.  This was overlooked initially because the matching Linux
function accepts both decimal and hexadecimal values.

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Igor Kozhukhov <[email protected]>
Issue openzfs#9125
@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Aug 21, 2019
Copy link
Contributor

@ikozhukhov ikozhukhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Aug 22, 2019
@behlendorf behlendorf merged commit 31b548f into openzfs:master Aug 22, 2019
@codecov
Copy link

codecov bot commented Aug 22, 2019

Codecov Report

Merging #9195 into master will increase coverage by 0.49%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9195      +/-   ##
==========================================
+ Coverage   79.22%   79.71%   +0.49%     
==========================================
  Files         400      279     -121     
  Lines      122001    81177   -40824     
==========================================
- Hits        96656    64711   -31945     
+ Misses      25345    16466    -8879
Flag Coverage Δ
#kernel 79.71% <ø> (-0.04%) ⬇️
#user ?

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9ebdfd...74762a4. Read the comment docs.

@behlendorf behlendorf deleted the issue-9125 branch April 19, 2021 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants