Fix automake program name transformations

[ghost]

Motivation and Context

Automake can perform program name transformations at install time. However, arc_summary has its own name transformation taking place, which interferes with the automake transforms. The automake transforms must be taken into account in order to resolve the conflict.

Description

The program name transform is a sed script available to make. The name of the arc_summary program must be transformed using this script in order to successfully rename it from arc_summary2 or arc_summary3 to arc_summary when program name transforms have been used.

How Has This Been Tested?

I have been building and testing ZFS on FreeBSD (and on Linux) with this change for a few months.
Try it at home with ./configure --program-suffix=foobar and a standard make && sudo make install DESTDIR=/tmp/suffixed

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Performance enhancement (non-breaking change which improves efficiency)
• Code cleanup (non-breaking change which makes code smaller or more readable)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation (a change to man pages or other documentation)

Checklist:

• My code follows the ZFS on Linux code style requirements.
• I have updated the documentation accordingly.
• I have read the contributing document.
• I have added tests to cover my changes.
• All new and existing tests passed.
• All commit messages are properly formatted and contain Signed-off-by.

[behlendorf]

Neat, I wasn't aware of this functionality. Is --program-transform-name needed by ZoF, or did you just happen to notice this functionality was missing?

[ghost]

We were at some point looking for ways to have ZoF and the in-tree ZFS utils coexist during testing/development, and one of the ideas was to add a suffix to the ZoF versions of the binaries. With a little research I found the program name transformation functionality, and this is where the build broke when I tried it out.

[behlendorf]

@mattmacy would you mind providing a second review for this.

[mattmacy]

LGTM

[gmelikov]

LGTM

Oops, didn't update the page :(

[codecov]

Codecov Report

Merging #9190 into master will increase coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #9190      +/-   ##
==========================================
+ Coverage   79.11%   79.17%   +0.05%     
==========================================
  Files         400      400              
  Lines      122000   122000              
==========================================
+ Hits        96524    96593      +69     
+ Misses      25476    25407      -69

Flag	Coverage Δ
#kernel	79.73% <ø> (ø)	⬆️
#user	67.13% <ø> (+0.15%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 325d288...92a9e1d. Read the comment docs.