Enhance ioctl number checks #9187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When checking ZFS_IOC_* numbers, print which numbers are wrong rather than silently failing. Signed-off-by: Ryan Moeller <[email protected]>
behlendorf
approved these changes
Aug 21, 2019
chrisrd
approved these changes
Aug 21, 2019
Codecov Report
@@ Coverage Diff @@
## master #9187 +/- ##
==========================================
+ Coverage 79.05% 79.12% +0.07%
==========================================
Files 400 400
Lines 122000 122001 +1
==========================================
+ Hits 96443 96534 +91
+ Misses 25557 25467 -90
Continue to review full report at Codecov.
|
behlendorf
added
Status: Accepted
ghost
deleted the
ghost
mentioned this pull request
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Dec 24, 2019
When checking ZFS_IOC_* numbers, print which numbers are wrong rather than silently failing. Reviewed-by: Chris Dunlop <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Ryan Moeller <[email protected]> Closes openzfs#9187
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Dec 27, 2019
When checking ZFS_IOC_* numbers, print which numbers are wrong rather than silently failing. Reviewed-by: Chris Dunlop <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Ryan Moeller <[email protected]> Closes openzfs#9187
tonyhutter
pushed a commit
that referenced
this pull request
Jan 23, 2020
When checking ZFS_IOC_* numbers, print which numbers are wrong rather than silently failing. Reviewed-by: Chris Dunlop <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Ryan Moeller <[email protected]> Closes #9187
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The test suite includes a program for basic low-level testing of ZFS ioctls. One of its functions validates the values of ZFS_IOC_* constants. The test is a long string of comparisons chained together with '&&'. If the test fails, there is no indication of which values were incorrect.
Description
When validating the ZFS_IOC_* numbers, print the comparisons that fail.
This was done using a short macro to minimize the code change and keep the code simple and readable.
How Has This Been Tested?
Passes ZTS
Types of changes
Checklist:
Signed-off-by.