Illumos 5134 - if ZFS_DEBUG or debug= is set, libzpool should enable debug prints #2669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FransUrbo
added a commit
to FransUrbo/zfs
that referenced
this pull request
Sep 5, 2014
…libzpool should enable debug prints Reviewed by: Christopher Siden [email protected] Reviewed by: Adam Leventhal [email protected] Original author: Matthew Ahrens References: https://www.illumos.org/projects/illumos-gate/issues/5134 https://reviews.csiden.org/r/82/ Ported by: Turbo Fredriksson <[email protected]>
|
Let's hold off on this one until it's pulled in to Illumos. |
|
Sure. I don't think it's working anyway. It's possible that ZoL is missing some important code or something but setting the variable and/or using the option doesn't seem to give the desired result - no extra output... |
|
Yes, our debug infrastructure is slightly different so this might take a little more investigation. |
|
How DO you run ZoL in/with debugging? Just using |
FransUrbo
force-pushed
the
illumos-5134
branch
2 times, most recently
from
75f2988 to
e320d8f
Compare
|
@behlendorf It's now accepted in Illumos-gate... |
FransUrbo
force-pushed
the
illumos-5134
branch
2 times, most recently
from
d5d22bf to
76053a1
Compare
…debug prints Reviewed by: Christopher Siden [email protected] Reviewed by: Adam Leventhal [email protected] References: https://www.illumos.org/projects/illumos-gate/issues/5134 illumos/illumos-gate@7fa49ea Porting notes: Run dprintf_setup() in main. Ported by: Turbo Fredriksson <[email protected]>
dasjoe
pushed a commit
to dasjoe/zfs
that referenced
this pull request
May 24, 2015
…debug prints 5134 if ZFS_DEBUG or debug= is set, libzpool should enable debug prints Reviewed by: Adam Leventhal <[email protected]> Reviewed by: Christopher Siden <[email protected]> Reviewed by: George Wilson <[email protected]> Reviewed by: Saso Kiselkov <[email protected]> Approved by: Dan McDonald <[email protected]> References: https://www.illumos.org/projects/illumos-gate/issues/5134 illumos/illumos-gate@7fa49ea Porting notes: Added dprintf_setup() to main in zfs_main.c and zpool_main.c. Ported by: Turbo Fredriksson <[email protected]> Signed-off-by: Brian Behlendorf <[email protected]> Closes openzfs#2669
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewed by: Christopher Siden [email protected]
Reviewed by: Adam Leventhal [email protected]
Original author: Matthew Ahrens
References:
https://www.illumos.org/projects/illumos-gate/issues/5134
illumos/illumos-gate@7fa49ea
Ported by: Turbo Fredriksson [email protected]