Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong free function in arc_hdr_decrypt #17079

Merged
merged 1 commit into from
Feb 22, 2025
Merged

Conversation

tuxoko
Copy link
Contributor

@tuxoko tuxoko commented Feb 21, 2025

Need to use arc_free_data_abd to free abd type buffer.

Motivation and Context

Found this when making some other changes.
Not sure if it's possible to hit or not.

Description

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

Need to use arc_free_data_abd to free abd type buffer.

Signed-off-by: Chunwei Chen <[email protected]>
Copy link
Member

@amotin amotin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Though it must be really rare and only when compressed ARC is disabled.

@amotin amotin added the Status: Accepted Ready to integrate (reviewed, tested) label Feb 21, 2025
@amotin amotin merged commit 682c5f6 into openzfs:master Feb 22, 2025
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants