Add more DDT tests #17049
Open
Add more DDT tests #17049
+183
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 12, 2025 09:10
Signed-off-by: Paul Dagnelie <[email protected]>
Signed-off-by: Paul Dagnelie <[email protected]>
amotin
reviewed
Feb 20, 2025
Comment on lines
+45
to
+47
| # we set the dedup log txg interval to 1, to get a log flush every txg, | ||
| # effectively disabling the log. without this it's hard to predict when and | ||
| # where things appear on-disk |
There was a problem hiding this comment.
Suggested change
| # we set the dedup log txg interval to 1, to get a log flush every txg, | |
| # effectively disabling the log. without this it's hard to predict when and | |
| # where things appear on-disk | |
| # We set the dedup log txg interval to 1, to get a log flush every txg, | |
| # effectively disabling the log. Without this it's hard to predict when the | |
| # entries appear in DDT ZAP |
And the same in the other test.
|
|
||
| log_must zpool create -f -o feature@block_cloning=disabled $TESTPOOL $DISKS | ||
|
|
||
| log_must zfs create -o recordsize=512 -o xattr=sa -o dedup=on $TESTPOOL/$TESTFS |
There was a problem hiding this comment.
Why do we care about xattr=sa here?
|
|
||
| log_must truncate -s 128k $mountpoint/f2 | ||
| sync_pool $TESTPOOL | ||
| sleep 1 |
| log_onexit cleanup | ||
|
|
||
| log_must create_pool $TESTPOOL $DISKS | ||
| log_must zfs create -o dedup=on -o recordsize=512 $TESTPOOL/$TESTFS |
There was a problem hiding this comment.
Suggested change
| log_must zfs create -o dedup=on -o recordsize=512 $TESTPOOL/$TESTFS | |
| log_must zfs create -o dedup=sha256 -o recordsize=512 $TESTPOOL/$TESTFS |
It seems below you depend on the algorithm.
| nleafs=$(zdb -dddd $TESTPOOL "$zap_obj" | grep "Leaf blocks:" | awk -F\: '{print($2);}') | ||
| log_must test $nleafs -lt $nleafs_old | ||
|
|
||
| log_pass "ZAP object shrank after rmeoving entries." |
There was a problem hiding this comment.
Suggested change
| log_pass "ZAP object shrank after rmeoving entries." | |
| log_pass "ZAP object shrank after removing entries." |
|
And please squash the commits and write some commit message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The new Fast Dedup feature has a lot of moving parts, and only some of them have tests. We have some tests for prefetch and quota, and a generic ZAP shrinking test, but we don't have anything for the pruning command or specific to DDT zap shrinking. We also don't have anything for the dedup log, but I added a test for that in #17038 .
Description
We add a couple small new tests for
zpool ddtpruneand DDT-specific ZAP shrinking.How Has This Been Tested?
Ran the ZTS with the new tests, they passed
Types of changes
Checklist:
Signed-off-by.