-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FreeBSD: exclude some includes when building libsa #16616
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if #ifdef _KERNEL
would be more appropriate. That is how I see the function calls are wrapped.
Using |
Thank you for the hint, PR updated. |
The function abd_alloc_from_pages() is used only in kernel. Excluding sys/vm.h, and vm/vm_page.h includes avoids dependency problems. Signed-off-by: Martin Matuska <[email protected]>
The function abd_alloc_from_pages() is used only in kernel. Excluding sys/vm.h, and vm/vm_page.h includes avoids dependency problems. Reviewed-by: Alexander Motin <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Martin Matuska <[email protected]> Closes openzfs#16616
The function abd_alloc_from_pages() is used only in kernel. Excluding sys/vm.h, and vm/vm_page.h includes avoids dependency problems. Reviewed-by: Alexander Motin <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Martin Matuska <[email protected]> Closes openzfs#16616
Motivation and Context
The function abd_alloc_from_pages() is not used in FreeBSD base libsa.
Excluding sys/vm.h, and vm/vm_page.h includes avoids dependency problems.
Description
Exclude abd_alloc_from_pages(), sys/vm.h, and vm/vm_page.h when building libsa.
How Has This Been Tested?
FreeBSD base build
Types of changes
Checklist:
Signed-off-by
.