Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sa_impl: fix SA header bitfield docs #16500

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

robn
Copy link
Member

@robn robn commented Sep 3, 2024

[Sponsors: Klara, Inc., Wasabi Technology, Inc.]

Motivation and Context

Docs didn't quite match, and I got confused.

Description

Just a little doc comment fix.

How Has This Been Tested?

Look at on-disk data in gdb, thought very hard.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

Off by one, confused me a while!

Sponsored-by: Klara, Inc.
Sponsored-by: Wasabi Technology, Inc.
Signed-off-by: Rob Norris <[email protected]>
@robn robn force-pushed the sa-header-bitfield-doc-fix branch from f7595c7 to 46438c8 Compare September 4, 2024 22:43
@behlendorf behlendorf merged commit ec02094 into openzfs:master Sep 17, 2024
19 of 20 checks passed
ptr1337 pushed a commit to CachyOS/zfs that referenced this pull request Nov 14, 2024
Off by one, confused me a while!

Sponsored-by: Klara, Inc.
Sponsored-by: Wasabi Technology, Inc.
Reviewed by: Brian Behlendorf <[email protected]>
Reviewed-by: Alexander Motin <[email protected]>
Reviewed-by: Tino Reichardt <[email protected]>
Signed-off-by: Rob Norris <[email protected]>
Closes openzfs#16500
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Jan 26, 2025
Off by one, confused me a while!

Sponsored-by: Klara, Inc.
Sponsored-by: Wasabi Technology, Inc.
Reviewed by: Brian Behlendorf <[email protected]>
Reviewed-by: Alexander Motin <[email protected]>
Reviewed-by: Tino Reichardt <[email protected]>
Signed-off-by: Rob Norris <[email protected]>
Closes openzfs#16500
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants