Python 3.10 edge case #12673
Merged
Python 3.10 edge case #12673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behlendorf
approved these changes
Oct 25, 2021
There was a fallback case I overlooked in the initial patch, with a similarly imperfect version extractor. Closes: openzfs#12045 Signed-off-by: Rich Ercolani <[email protected]>
behlendorf
added
Status: Accepted
13 tasks
behlendorf
pushed a commit
to behlendorf/zfs
that referenced
this pull request
May 2, 2022
There was a fallback case I overlooked in the initial patch, with a similarly imperfect version extractor. Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Rich Ercolani <[email protected]> Closes openzfs#12045 Closes openzfs#12673
behlendorf
pushed a commit
that referenced
this pull request
May 4, 2022
There was a fallback case I overlooked in the initial patch, with a similarly imperfect version extractor. Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Rich Ercolani <[email protected]> Closes #12045 Closes #12673
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
I missed a fallback case, which was also flawed at Python version checks and someone got bitten in #12045.
Description
Just take their suggested version extractor fix.
In the future, I should probably try merging this with upstream's other fixes (though they still try using string comparison for versions...).
How Has This Been Tested?
Commented out all the "only run this in the fallback case" lines, tried running it, verified it shook the correct version out at a quick glance, uncommented everything and pushed.
Types of changes
Checklist:
Signed-off-by.