-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more sanity testing for zdb input args #10243
Conversation
Codecov Report
@@ Coverage Diff @@
## master #10243 +/- ##
==========================================
- Coverage 79.28% 79.27% -0.01%
==========================================
Files 389 389
Lines 123402 123402
==========================================
- Hits 97834 97823 -11
- Misses 25568 25579 +11
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's good to see some additional zdb
test coverage!
Signed-off-by: sara hartse <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: John Kennedy <[email protected]> Signed-off-by: sara hartse <[email protected]> Closes openzfs#10243 (cherry picked from commit 89a6610)
Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: John Kennedy <[email protected]> Signed-off-by: sara hartse <[email protected]> Closes openzfs#10243
Motivation and Context
There's a lot going on in ZDB, in the past as I've expanded it's features I've accidentally introduced regressions. I decided to take a stab at extending some of our testing.
Description
Add positive argument testing to confirm that flags that we expect to be available don't result in failures or crashes.
Modify the existing negative arg test to have a more explicit name and correct the test by adding a
pool
argument to the zdb invocation (some tests with valid flags were erroneously passing because they were missing the pool arg).How Has This Been Tested?
Types of changes
Checklist:
Signed-off-by
.