Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FreeBSD tunables #10203

Merged
merged 1 commit into from
Apr 15, 2020
Merged

Update FreeBSD tunables #10203

merged 1 commit into from
Apr 15, 2020

Conversation

ghost
Copy link

@ghost ghost commented Apr 14, 2020

Motivation and Context

Description

Remove some obsolete legacy compat, rename some misnamed, and add some
missing tunables for FreeBSD.

How Has This Been Tested?

ZTS on FreeBSD

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

  • My code follows the ZFS on Linux code style requirements.
  • I have updated the documentation accordingly.
  • I have read the contributing document.
  • I have added tests to cover my changes.
  • I have run the ZFS Test Suite with this change applied.
  • All commit messages are properly formatted and contain Signed-off-by.

@ghost ghost added the Status: Code Review Needed Ready for review and testing label Apr 14, 2020
@ghost ghost force-pushed the tunables branch from 9840719 to 1256b97 Compare April 14, 2020 19:56
Remove some obsolete legacy compat, rename some misnamed, and add some
missing tunables for FreeBSD.

Signed-off-by: Ryan Moeller <[email protected]>
@ghost ghost force-pushed the tunables branch from 1256b97 to 8e1abaa Compare April 15, 2020 01:13
@codecov-io
Copy link

codecov-io commented Apr 15, 2020

Codecov Report

Merging #10203 into master will increase coverage by 0.35%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10203      +/-   ##
==========================================
+ Coverage   79.49%   79.84%   +0.35%     
==========================================
  Files         388      290      -98     
  Lines      123392    83452   -39940     
==========================================
- Hits        98088    66635   -31453     
+ Misses      25304    16817    -8487     
Flag Coverage Δ
#kernel 79.84% <ø> (-0.16%) ⬇️
#user ?
Impacted Files Coverage Δ
module/zfs/ddt.c 83.16% <ø> (-5.09%) ⬇️
module/zfs/txg.c 91.34% <ø> (-2.38%) ⬇️
module/icp/asm-x86_64/aes/aeskey.c 0.00% <0.00%> (-100.00%) ⬇️
module/icp/algs/modes/gcm_generic.c 11.11% <0.00%> (-88.89%) ⬇️
module/zfs/vdev_raidz_math_sse2.c 14.39% <0.00%> (-84.85%) ⬇️
module/icp/algs/aes/aes_impl_generic.c 0.82% <0.00%> (-69.55%) ⬇️
module/icp/algs/skein/skein_block.c 31.94% <0.00%> (-68.06%) ⬇️
module/icp/algs/aes/aes_impl_x86-64.c 40.00% <0.00%> (-60.00%) ⬇️
module/icp/algs/edonr/edonr.c 45.72% <0.00%> (-42.59%) ⬇️
module/zfs/gzip.c 46.15% <0.00%> (-38.47%) ⬇️
... and 278 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b1139e...8e1abaa. Read the comment docs.

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Apr 15, 2020
@behlendorf behlendorf merged commit a7929f3 into openzfs:master Apr 15, 2020
@ghost ghost deleted the tunables branch April 15, 2020 18:51
jsai20 pushed a commit to jsai20/zfs that referenced this pull request Mar 30, 2021
Remove some obsolete legacy compat, rename some misnamed, and add some
missing tunables for FreeBSD.

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ryan Moeller <[email protected]>
Closes openzfs#10203
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants