Skip add metadata for SPIR target #9044
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sub PR of #9042 |
akuegel
reviewed
Feb 13, 2024
| @@ -50,6 +50,7 @@ limitations under the License. | |||
| #include "llvm/Support/Casting.h" | |||
| #include "llvm/Support/CodeGen.h" | |||
| #include "llvm/Support/raw_ostream.h" | |||
| #include "llvm/TargetParser/Triple.h" | |||
There was a problem hiding this comment.
This needs a corresponding dependency in the BUILD file for the llvm_util target.
ShengYang1
force-pushed
the
yang/metadata
branch
from
f8365cd to
1a71d76
Compare
akuegel
approved these changes
Feb 20, 2024
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Feb 20, 2024
Imported from GitHub PR openxla/xla#9044 This is a sub PR to add SPIR target in openxla. There is no need to add range metadata for SPIR target, so just skip it in `AddRangeMetadata` function. Copybara import of the project: -- 1a71d76809e045c428d9a98024366c13ccacf3d9 by Sheng, Yang <[email protected]>: Skip add metadata for SPIR target Merging this change closes #9044 PiperOrigin-RevId: 608548655
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a sub PR to add SPIR target in openxla.
There is no need to add range metadata for SPIR target, so just skip it in
AddRangeMetadatafunction.