Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sycl build target #10244

Closed
wants to merge 2 commits into from
Closed

Add sycl build target #10244

wants to merge 2 commits into from

Conversation

ShengYang1
Copy link
Contributor

It is a sub PR of #9042.
Then we can build xla with sycl support like: bazel build --config=sycl xxx

@github-actions github-actions bot added the kokoro:force-run Forces CI to rerun label Mar 5, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Forces CI to rerun label Mar 5, 2024
@Zantares Zantares mentioned this pull request Mar 5, 2024
Draft
@dimitar-asenov dimitar-asenov requested a review from ddunl March 5, 2024 12:17
@ddunl
Copy link
Member

ddunl commented Mar 12, 2024

Sorry for the delay in review here. Thanks for the PR! I imagine this is going to require a patch on our side, so this may take a while to merge.

copybara-service bot pushed a commit to tensorflow/tensorflow that referenced this pull request Mar 12, 2024
@ShengYang1 @tensorflower-gardener
PR #10244: Add sycl build target
24a1684 
Imported from GitHub PR openxla/xla#10244

It is a sub PR of openxla/xla#9042.
Then we can build xla with sycl support like: `bazel build --config=sycl xxx`
Copybara import of the project:

--
e1bc7ac90f3403a477ba14533dea972de6a2c262 by Sheng, Yang <[email protected]>:

Add sycl build target

Merging this change closes #10244

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#10244 from Intel-tensorflow:yang/syclbuild e1bc7ac90f3403a477ba14533dea972de6a2c262
PiperOrigin-RevId: 615176784
@copybara-service copybara-service bot mentioned this pull request Mar 12, 2024
Closed
@Zantares
Copy link

Sorry for the delay in review here. Thanks for the PR! I imagine this is going to require a patch on our side, so this may take a while to merge.

Hi @ddunl , what kind of patch is needed here, can we provide any help?
Another thing is that I have discussed the build requirement with @penpornk . We will simplify this PR by removing toolchain part first. Then making it compilable for better code quality.

@ddunl
Copy link
Member

ddunl commented Mar 13, 2024

As of right now I think the PR as structured is fine, it's just a build system difference internally vs externally that's the cause for the patch. Totally our responsibility to figure out. I'll ping here though if I find a change to this PR that could be helpful. I'll try to have the patch done by Friday. Thanks again!!

@kamaljeeti
Copy link
Contributor

Hi @ddunl , any update on this PR? Thanks.

@kamaljeeti kamaljeeti added kokoro:force-run Forces CI to rerun and removed kokoro:force-run Forces CI to rerun labels Mar 28, 2024
@kamaljeeti kamaljeeti requested a review from penpornk April 2, 2024 04:26
@Zantares Zantares mentioned this pull request Apr 2, 2024
Merged
@ddunl
Copy link
Member

ddunl commented Apr 4, 2024

Working on my patch now, should be done soon. Very sorry for the delay here!

copybara-service bot pushed a commit that referenced this pull request Apr 5, 2024
@ShengYang1 @copybara-github
Add sycl build target #10244
a5e019c 
PiperOrigin-RevId: 620365120
@copybara-service copybara-service bot mentioned this pull request Apr 5, 2024
Merged
copybara-service bot pushed a commit that referenced this pull request Apr 5, 2024
@ShengYang1 @copybara-github
Add sycl build target #10244
aa771b6 
PiperOrigin-RevId: 620365120
copybara-service bot pushed a commit that referenced this pull request Apr 5, 2024
@ShengYang1 @copybara-github
Add sycl build target #10244
7f205c1 
PiperOrigin-RevId: 620365120
copybara-service bot pushed a commit that referenced this pull request Apr 5, 2024
@ShengYang1 @copybara-github
Add sycl build target #10244
fe60344 
PiperOrigin-RevId: 620365120
ddunl
ddunl reviewed Apr 9, 2024
View reviewed changes
third_party/tsl/third_party/gpus/sycl_configure.bzl
@@ -0,0 +1,547 @@
"""Repository rule for SYCL autoconfiguration.

`sycl_configure` depends on the following environment variables:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we list which environment variables are depended on? My patch is done now, so just waiting on internal approvals, sorry again for the delay!!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to hear the patch is done. I have updated the environment variables in comments.

@github-actions github-actions bot added the kokoro:force-run Forces CI to rerun label Apr 10, 2024
copybara-service bot pushed a commit that referenced this pull request Apr 10, 2024
@ShengYang1 @copybara-github
Add sycl build target #10244
5252e74 
PiperOrigin-RevId: 620365120
copybara-service bot pushed a commit that referenced this pull request Apr 10, 2024
@ShengYang1 @copybara-github
Add sycl build target #10244
3b954f4 
PiperOrigin-RevId: 620365120
copybara-service bot pushed a commit that referenced this pull request Apr 10, 2024
@ShengYang1 @copybara-github
Add sycl build target #10244
1bd227b 
PiperOrigin-RevId: 623599115
@kamaljeeti
Copy link
Contributor

Hi @ddunl , can you look into this once? Thanks.

@Zantares
Copy link

Zantares commented May 6, 2024

This is PR is merged by another PR: #11271. It can be closed now.

@ShengYang1 ShengYang1 closed this May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddunl ddunl ddunl approved these changes

@dimitar-asenov dimitar-asenov Awaiting requested review from dimitar-asenov

@penpornk penpornk Awaiting requested review from penpornk

Assignees

@xla-rotation xla-rotation

@kamaljeeti kamaljeeti

Labels
kokoro:force-run Forces CI to rerun
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ShengYang1 @ddunl @Zantares @kamaljeeti @kokoro-team @xla-rotation