Increase the json string byte size for diagnostic response payloads. #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ytes of diagnostic payload responses.
notsig11
reviewed
Sep 27, 2016
|
@notsig11 fantastic idea! |
added 3 commits
October 3, 2016 15:50
…in full size multi-frame diagnostic responses. still need to update subcommits.
… buffer in order to get bytes out over USB.
zacnelson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was originally set at 67 bytes for arbitrary reasons? 67 byte array = 32 bytes represented as ascii characters. Plus 3 for overhead or quotations?
In this case, the diagnostic response payload is limited to 255 bytes so (255 * 2)+3 = 513 needed to store the payload as a string.
When trying this on Android, I ran into a bug. Not sure if it's on the Android side or on the VI side. I'll create an issue on Android so we can track it down. So for now I'll leave this as a draft pull request.