olsrd: fix APK package build #1085
Conversation
|
Please backport to openwrt-24.10 branch as well, just in case it's decided to activate APK there as well ❤️ |
|
But we wanted the user to be able to select the correct dependency themselves? If someone wants to use iptables, they should do. Maybe deleting the dependency completely would be a solution? |
Yes you're probably right, better to not force iptables-nft. I'll update it |
PolynomialDivision
force-pushed
the
olsrd-apk
branch
from
143791e to
132ff90
Compare
With the switch from OPKG to APK, we can't continue the
sloppy use of virtual packages. We now need to specify the
providing package. We don't want to force iptables-nft on
everyone though. The simplest solution is to drop the
dependency entirely - users will most likely already
depend on it separately.
For reference, the attempt to install the virtual package
results in the following error from APK:
ERROR: unable to select packages:
ip6tables (virtual):
note: please select one of the 'provided by'
packages explicitly
provided by: ip6tables-nft
ip6tables-zz-legacy
required by: olsrd-2024.06.09~d72be9ad-r1[ip6tables]
iptables (virtual):
note: please select one of the 'provided by'
packages explicitly
provided by: iptables-nft iptables-zz-legacy
required by: olsrd-2024.06.09~d72be9ad-r1[iptables]
Suggested-by: Packet Please <[email protected]>
Link: openwrt#1085
[Due to the real name policy, list the author as me, with
permission granted by Packet Please.]
Signed-off-by: Nick Hainke <[email protected]>
PolynomialDivision
force-pushed
the
olsrd-apk
branch
from
132ff90 to
1634096
Compare
|
I changed the author to myself to ensure a valid sign-off, with approval from @pktpls. It seems the real name discussion is still ongoing: openwrt/actions-shared-workflows@12d9551 |
|
This PR is not needed, sorry, I was using it wrong 😬 If any packages declares iptables/ip6tables as its dependency, then something needs to select a package providing it. I just selected iptables-nft and ip6tables-nft further up the dependency tree, and it's now fine. The change with APK is not that we can't depend on virtual packages anymore, it's apparantly that there's no default provider selection anymore. |
Maintainer: @PolynomialDivision hi :)
Compile tested: x86_64
Run tested: x86/64
Description:
Can't use the iptables meta packages apparantly: