-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bird2: add test.sh for bird #1064
Conversation
CI fails:
|
Need to add 2>&1 to redirect stderr to stdout |
Signed-off-by: Bradford Zhang <[email protected]>
It should be fixed now, thanks for your waiting~ :D |
What's the purpose of having this? Does is catch any actual errors? |
Just to test if bird is installed correctly. |
Bradford Zhang ***@***.***> writes:
> What's the purpose of having this? Does is catch any actual errors?
Just to test if bird is installed correctly.
But why is such a test useful? Did you run into any particular issue
where this test helps/would have helped? :)
|
In #1052 @BKPepe mentioned there is no test script for this package in CI, so this script just to make sure bird2 is installed correctly and can run without any error in dependency. |
Alright, makes sense. But please bump the package revision along with the change :) |
The version is bumped in previous commits |
Sure, but that's a week ago. PKG_RELEASE should be bumped along with this change or there will be two different packages with no indication of the change... |
Got it, so i need to edit PKG_RELEASE to 2? :D |
This file is not included in the package itself, it it just in this repository to be sure that bird does not segfault immediately or that it runs. |
Maintainer: @tohojo
Compile tested: x86_64 generic
Run tested: x86_64 generic test done
Description: add test.sh for bird2