Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opennds: update to version 10.2.0 #1034

Merged
merged 1 commit into from
Nov 28, 2023
Merged

opennds: update to version 10.2.0 #1034

merged 1 commit into from
Nov 28, 2023

Conversation

bluewavenet
Copy link
Contributor

@bluewavenet bluewavenet commented Nov 23, 2023

Maintainer: Rob White [email protected]

Compile tested: arm_cortex-a7_neon-vfpv4, mipsel_24kc, x86-64

Run tested: arm_cortex-a7_neon-vfpv4, mipsel_24kc, x86-64; on snapshot, 23.05, 22.03

Description:
opennds (10.2.0) - This version is a minor upgrade that introduces some significant additional functionality.
In addition it includes numerous enhancements bug fixes and cosmetic fixes.

Additional functionality includes:

  • Pre-emptive Client Lists
  • Autonomous Block Lists
  • Internet hosted https FAS support for resource limited routers
  • Fair Usage Policy

Details can be found here:
https://github.com/openNDS/openNDS/releases/tag/v10.2.0

Signed-off-by: Rob White [email protected]

@bluewavenet
Copy link
Contributor Author

@mwarning @PolynomialDivision @BKPepe
All tests passed. Good to go....

@BKPepe
Copy link
Member

BKPepe commented Nov 23, 2023

I do have one remark here. We don't need to copy&paste things from your tagged release in the commit description. Just point there your tag, where users which are interested in it can find it.

Overally, my idea is that in the commit description should be only relevant changes to package or files, which are here (init script, config file, etc.) and not describing all those changes which was done in the source code. It makes everything huge, which could lead to misunderstanding.

So...
commit description:

@bluewavenet
Copy link
Contributor Author

@BKPepe
I have done it this way for some considerable time, born of frustration of finding commit/pr comments that convey almost zero information, making it very hard work to follow what is actually going on.

It is very refreshing to get feedback on this and yes I wholeheartedly agree with your idea as it will convey the same information as my method but in a much more condensed and readable form - for the same minimal effort that my verbose cut&paste involves.

I have edited accordingly. How does it look now?

@BKPepe
Copy link
Member

BKPepe commented Nov 24, 2023

Yeah, its better! You got the idea in the PR, which you edited. Good work.

Next time, we can keep working on it to improve it even more. :)

Please do the same thing in your commit and force push it, then I will merge it.

@bluewavenet
Copy link
Contributor Author

@BKPepe

Next time, we can keep working on it to improve it even more

Indeed.
A user guide or similar would be useful. Do you know if there is one? I can't find anything, particularly with regards to the many options for the makefile....

Maintainer: Rob White [email protected]

Compile tested: arm_cortex-a7_neon-vfpv4, mipsel_24kc, x86-64

Run tested: arm_cortex-a7_neon-vfpv4, mipsel_24kc, x86-64; on snapshot, 23.05, 22.03

Description:
opennds (10.2.0) - This version is a minor upgrade that introduces some significant additional functionality.
In addition it includes numerous enhancements bug fixes and cosmetic fixes.

Additional functionality includes:

 * Pre-emptive Client Lists
 * Autonomous Block Lists
 * Internet hosted https FAS support for resource limited routers
 * Fair Usage Policy

Details can be found here:
https://github.com/openNDS/openNDS/releases/tag/v10.2.0

Signed-off-by: Rob White <[email protected]>
@bluewavenet
Copy link
Contributor Author

@BKPepe

Please do the same thing in your commit and force push it, then I will merge it.

Done.

@bluewavenet
Copy link
Contributor Author

@BKPepe

Ready to go...

@BKPepe BKPepe merged commit a5ec54a into openwrt:master Nov 28, 2023
11 checks passed
@BKPepe
Copy link
Member

BKPepe commented Nov 28, 2023

A user guide or similar would be useful. Do you know if there is one? I can't find anything, particularly with regards to the many options for the makefile....

Hmm, I dont think so. :) Best practices applies here.

@bluewavenet
Copy link
Contributor Author

@BKPepe
Thank you!

Best practices applies here.

Lol - So is there a list of best practices? ;-D

@BKPepe
Copy link
Member

BKPepe commented Nov 28, 2023

Haha, good joke. Nope. =D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants