-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
opennds: update to version 10.2.0 #1034
Conversation
@mwarning @PolynomialDivision @BKPepe |
I do have one remark here. We don't need to copy&paste things from your tagged release in the commit description. Just point there your tag, where users which are interested in it can find it. Overally, my idea is that in the commit description should be only relevant changes to package or files, which are here (init script, config file, etc.) and not describing all those changes which was done in the source code. It makes everything huge, which could lead to misunderstanding. So...
|
@BKPepe It is very refreshing to get feedback on this and yes I wholeheartedly agree with your idea as it will convey the same information as my method but in a much more condensed and readable form - for the same minimal effort that my verbose cut&paste involves. I have edited accordingly. How does it look now? |
Yeah, its better! You got the idea in the PR, which you edited. Good work. Next time, we can keep working on it to improve it even more. :) Please do the same thing in your commit and force push it, then I will merge it. |
Indeed. |
Maintainer: Rob White [email protected] Compile tested: arm_cortex-a7_neon-vfpv4, mipsel_24kc, x86-64 Run tested: arm_cortex-a7_neon-vfpv4, mipsel_24kc, x86-64; on snapshot, 23.05, 22.03 Description: opennds (10.2.0) - This version is a minor upgrade that introduces some significant additional functionality. In addition it includes numerous enhancements bug fixes and cosmetic fixes. Additional functionality includes: * Pre-emptive Client Lists * Autonomous Block Lists * Internet hosted https FAS support for resource limited routers * Fair Usage Policy Details can be found here: https://github.com/openNDS/openNDS/releases/tag/v10.2.0 Signed-off-by: Rob White <[email protected]>
Done. |
Ready to go... |
Hmm, I dont think so. :) Best practices applies here. |
@BKPepe
Lol - So is there a list of best practices? ;-D |
Haha, good joke. Nope. =D |
Maintainer: Rob White [email protected]
Compile tested: arm_cortex-a7_neon-vfpv4, mipsel_24kc, x86-64
Run tested: arm_cortex-a7_neon-vfpv4, mipsel_24kc, x86-64; on snapshot, 23.05, 22.03
Description:
opennds (10.2.0) - This version is a minor upgrade that introduces some significant additional functionality.
In addition it includes numerous enhancements bug fixes and cosmetic fixes.
Additional functionality includes:
Details can be found here:
https://github.com/openNDS/openNDS/releases/tag/v10.2.0
Signed-off-by: Rob White [email protected]