Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shairport-sync: add drift and ALSA mixer config options #25922

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

willmo
Copy link

@willmo willmo commented Feb 9, 2025

Allow setting drift_tolerance_in_seconds, which replaces the now-deprecated drift option.

Also allow setting alsa.mixer_control_index, which is necessary to use the hardware mixer correctly on some devices (like the Apple USB-C Headphone Adapter when a headset is plugged in).

Maintainer: @mikebrady @neheb @thess
Compile/run tested: ramips, Cudy TR1200 v1, OpenWrt 24.10-SNAPSHOT, r28242-1eff737906

@neheb
Copy link
Contributor

neheb commented Feb 9, 2025

Need a PKG_RELEASE bump.

@willmo willmo force-pushed the shairport-sync-config branch from 6f8771c to 5605343 Compare February 10, 2025 06:38
@willmo
Copy link
Author

willmo commented Feb 10, 2025

Fixed, sorry.

@willmo willmo force-pushed the shairport-sync-config branch from 5605343 to 39b812c Compare February 11, 2025 00:22
Allow setting drift_tolerance_in_seconds, which replaces the
now-deprecated drift option.

Also allow setting alsa.mixer_control_index, which is necessary to use
the hardware mixer correctly on some devices (like the Apple USB-C
Headphone Adapter when a headset is plugged in).

Signed-off-by: Will Mortensen <[email protected]>
@willmo willmo force-pushed the shairport-sync-config branch from 39b812c to e080ae2 Compare February 22, 2025 22:58
@willmo
Copy link
Author

willmo commented Feb 22, 2025

Any more feedback on this?

@neheb
Copy link
Contributor

neheb commented Feb 22, 2025

2025-02-22T23:39:14.9731109Z make[3]: Entering directory '/builder/build_dir/target-aarch64_generic_musl/popt-1.19'
2025-02-22T23:39:14.9732750Z CDPATH="${ZSH_VERSION+.}:" && cd . && /bin/bash '/builder/build_dir/target-aarch64_generic_musl/popt-1.19/build-aux/missing' aclocal-1.16 -I m4
2025-02-22T23:39:14.9757474Z a - ../objects/panel.o
2025-02-22T23:39:14.9758154Z a - ../objects/p_above.o
2025-02-22T23:39:14.9758939Z a - ../objects/p_below.o
2025-02-22T23:39:14.9759683Z a - ../objects/p_bottom.o
2025-02-22T23:39:14.9760064Z a - ../objects/p_delete.o
2025-02-22T23:39:14.9760420Z a - ../objects/p_hide.o
2025-02-22T23:39:14.9760757Z a - ../objects/p_hidden.o
2025-02-22T23:39:14.9761110Z a - ../objects/p_move.o
2025-02-22T23:39:14.9761451Z a - ../objects/p_new.o
2025-02-22T23:39:14.9761795Z a - ../objects/p_replace.o
2025-02-22T23:39:14.9762152Z a - ../objects/p_show.o
2025-02-22T23:39:14.9762505Z a - ../objects/p_top.o
2025-02-22T23:39:14.9762868Z a - ../objects/p_update.o
2025-02-22T23:39:14.9763657Z a - ../objects/p_user.o
2025-02-22T23:39:14.9764043Z a - ../objects/p_win.o
2025-02-22T23:39:14.9765825Z ranlib ../lib/libpanel.a
2025-02-22T23:39:14.9783608Z /builder/staging_dir/host/bin/aclocal-1.16: 2: /builder/staging_dir/host/bin/aclocal.real: not found
2025-02-22T23:39:14.9864317Z make[4]: Leaving directory '/builder/build_dir/hostpkg/ncurses-6.4/panel'
2025-02-22T23:39:14.9865246Z ( cd "menu" && make -w DESTDIR="" RPATH_LIST="/builder/staging_dir/hostpkg/lib" libs )
2025-02-22T23:39:14.9892889Z WARNING: 'aclocal-1.16' is missing on your system.
2025-02-22T23:39:14.9893517Z          You should only need it if you modified 'acinclude.m4' or
2025-02-22T23:39:14.9895670Z          'configure.ac' or m4 files included by 'configure.ac'.
2025-02-22T23:39:14.9897113Z          The 'aclocal' program is part of the GNU Automake package:
2025-02-22T23:39:14.9897731Z          <https://www.gnu.org/software/automake>
2025-02-22T23:39:14.9898322Z          It also requires GNU Autoconf, GNU m4 and Perl in order to run:
2025-02-22T23:39:14.9899098Z          <https://www.gnu.org/software/autoconf>
2025-02-22T23:39:14.9899581Z          <https://www.gnu.org/software/m4/>
2025-02-22T23:39:14.9900044Z          <https://www.perl.org/>
2025-02-22T23:39:14.9900543Z make[3]: *** [Makefile:440: aclocal.m4] Error 127
2025-02-22T23:39:14.9901238Z make[3]: Leaving directory '/builder/build_dir/target-aarch64_generic_musl/popt-1.19'
2025-02-22T23:39:14.9902176Z make[2]: *** [Makefile:57: /builder/build_dir/target-aarch64_generic_musl/popt-1.19/.built] Error 2
2025-02-22T23:39:14.9904155Z make[2]: Leaving directory '/builder/feeds/base/package/libs/popt'
2025-02-22T23:39:14.9917857Z time: package/feeds/base/popt/compile#2.58#3.70#8.55
2025-02-22T23:39:14.9935354Z make[4]: Entering directory '/builder/build_dir/hostpkg/ncurses-6.4/menu'
2025-02-22T23:39:14.9935976Z rm -f ../include/menu.h
2025-02-22T23:39:14.9941323Z     ERROR: package/feeds/base/popt failed to build.
2025-02-22T23:39:14.9956014Z make[1]: *** [package/Makefile:189: package/feeds/base/popt/compile] Error 1

ping @robimarko

@neheb
Copy link
Contributor

neheb commented Feb 22, 2025

If I had to guess @Ansuel broke PKG_FIXUP:=autoreconf

@robimarko
Copy link
Contributor

Hm, I am yet to find a way to reproduce any of these

@robimarko
Copy link
Contributor

Ok, it seems that only SDK is affected, that makes it reproducible.

@neheb
Copy link
Contributor

neheb commented Feb 23, 2025

Yep: openwrt/openwrt#18073

@robimarko
Copy link
Contributor

robimarko commented Feb 23, 2025

Well, even crazier is the fact that when I build an SDK locally (In Docker using the same image as used for Dockers in CI) then it just works and I cannot reproduce it, only when using the snapshot SDK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants