Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

banip: Block UDP ports for HTTP/3 #25830

Merged
merged 1 commit into from
Jan 25, 2025
Merged

banip: Block UDP ports for HTTP/3 #25830

merged 1 commit into from
Jan 25, 2025

Conversation

jorti
Copy link
Contributor

@jorti jorti commented Jan 25, 2025

Block HTTP/3 by including UDP in the feeds that have the 80 443 ports in their flag.

Maintainer: @dibdot
Compile tested: -
Run tested: OpenWrt 24.10.0-rc2 r28161-ea17e958b9 on Linksys E8450 (UBI)

Description:
Block HTTP/3 in all feeds that select the HTTP ports.
Note that there's the caveat that it will block 80/udp too as the flag field is not expressive enough to include only 443/udp.

@dibdot
Copy link
Contributor

dibdot commented Jan 25, 2025

@jorti Looks good to me - thanks. Please update the readme feed table and bump the package release as well.

@dibdot
Copy link
Contributor

dibdot commented Jan 25, 2025

great, finally please amend your changes in your PR. Please check the contributing.md for details.

Thanks again!

Block HTTP/3 by including UDP in the feeds that have the 80 443 ports in
their flag.

Signed-off-by: Juan Orti Alcaine <[email protected]>
@jorti
Copy link
Contributor Author

jorti commented Jan 25, 2025

@dibdot I squashed the commits. Let me know if there's anything missing.

@dibdot dibdot merged commit f80fbec into openwrt:master Jan 25, 2025
12 checks passed
@dibdot
Copy link
Contributor

dibdot commented Jan 25, 2025

Many thanks, applied to master!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants