Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

netatalk: update to 4.1.1 #25752

Merged
merged 3 commits into from
Feb 2, 2025
Merged

netatalk: update to 4.1.1 #25752

merged 3 commits into from
Feb 2, 2025

Conversation

APCCV
Copy link
Contributor

@APCCV APCCV commented Jan 15, 2025 •
edited
Loading

Maintainer: Antonio Pastor / @APCCV
Compile tested: ipq806x (24.10-rc4, snapshot)
Run tested: ipq806x - C2600 (snapshot): install apk, start/stop services & review logs, share to MacOS, check nbplkup.

Description:

  • update to version 4.1.1
  • add small (AFP only) and full (everything possible plus build system config) variants
  • add uci support
  • include dependency to kernel module where appropriate

@APCCV APCCV marked this pull request as draft January 15, 2025 06:57
@APCCV APCCV force-pushed the master branch 2 times, most recently from b56ed90 to db5f97e Compare January 15, 2025 13:15
@APCCV APCCV marked this pull request as ready for review January 15, 2025 13:15
@APCCV
Copy link
Contributor Author

APCCV commented Jan 15, 2025

When merged please backport to stable version.

BKPepe
BKPepe requested changes Jan 15, 2025
View reviewed changes
Copy link
Member

@BKPepe BKPepe left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is getting huge, which results to be more complicated and this very hard to review.

net/netatalk/Makefile Outdated Show resolved Hide resolved
net/netatalk/Makefile Outdated Show resolved Hide resolved
net/netatalk/Makefile Outdated Show resolved Hide resolved
@APCCV
Copy link
Contributor Author

APCCV commented Jan 15, 2025 •
edited
Loading

This is getting huge, which results to be more complicated and this very hard to review.

This should be the end of it. I won't be adding more stuff to it. Should be version bumps from here on.

@APCCV APCCV force-pushed the master branch 3 times, most recently from 2500ce7 to 6d7a314 Compare January 15, 2025 21:24
@APCCV APCCV requested a review from BKPepe January 15, 2025 21:57
@APCCV APCCV force-pushed the master branch 3 times, most recently from bd0842a to cf894a8 Compare January 19, 2025 02:34
@APCCV APCCV changed the title netatalk: update to 4.1.0 netatalk: update to 4.1.1 Jan 21, 2025
@APCCV APCCV force-pushed the master branch 2 times, most recently from ab01b86 to d9e166d Compare January 21, 2025 00:04
@APCCV
Copy link
Contributor Author

APCCV commented Jan 21, 2025

Alright - it's 4.1.1 now. Tested with new version upstream. All good.

@APCCV
Copy link
Contributor Author

APCCV commented Jan 24, 2025

@BKPepe anything I can do to help move this forward? Changes you requested are done.
I know package releases are not linked to OpenWrt releases, but regardless would prefer this to be in 24.10 (just noticed rc6 will be out tomorrow).

1715173329
1715173329 reviewed Jan 26, 2025
View reviewed changes
net/netatalk/Makefile Outdated Show resolved Hide resolved
net/netatalk/files/afpd.init Outdated Show resolved Hide resolved
net/netatalk/files/afpd.init Outdated Show resolved Hide resolved
net/netatalk/files/afpd.init Outdated Show resolved Hide resolved
net/netatalk/files/afpd.init Outdated Show resolved Hide resolved
@APCCV APCCV requested a review from 1715173329 January 26, 2025 23:29
1715173329
1715173329 reviewed Jan 30, 2025
View reviewed changes
Copy link
Member

@1715173329 1715173329 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm

net/netatalk/files/a2boot.init Outdated Show resolved Hide resolved
net/netatalk/files/afpd.init Outdated Show resolved Hide resolved
net/netatalk/files/afpd.init Outdated Show resolved Hide resolved
net/netatalk/files/atalkd.init Outdated Show resolved Hide resolved
net/netatalk/files/papd.init Outdated Show resolved Hide resolved
net/netatalk/files/timelord.init Outdated Show resolved Hide resolved
net/netatalk/files/macipgw.init Outdated Show resolved Hide resolved
@APCCV
Copy link
Contributor Author

APCCV commented Jan 31, 2025

otherwise lgtm

Sorry I misunderstood your previous comment and added those extra lines. They are out as requested.
Cheers!

@APCCV APCCV requested a review from 1715173329 January 31, 2025 00:02
@APCCV
Copy link
Contributor Author

APCCV commented Jan 31, 2025

Oh... once merged, please do not backport this to 23.05.
23.05 lacks a base files patch (PR was not accepted) so kmod-appletalk is not available. Base an full packages will not build.
Do backport to 24.10 please.

@APCCV
netatalk: update to 4.1.1
7ef6176 
Signed-off-by: Antonio Pastor <[email protected]>
Antonio Pastor added 2 commits February 1, 2025 23:16
@APCCV
netatalk: create small and full variants
2bd76c5 
Small version includes only AFP file sharing to minimize size.
Base version adds AppleTalk. This matches the contents of the
existing package.
Full version includes everything that OpenWrt can support and
configuration option for build system (menuconfig).

Signed-off-by: Antonio Pastor <[email protected]>
@APCCV
netatalk: add uci support
f711589 
Signed-off-by: Antonio Pastor <[email protected]>
@1715173329 1715173329 merged commit 900e71b into openwrt:master Feb 2, 2025
12 checks passed
@APCCV
Copy link
Contributor Author

APCCV commented Feb 3, 2025

Great! Thank you!
Do I need a separate PR to backport to 24.10? I'll open it in a couple days if I don't hear otherwise.

@1715173329
Copy link
Member

Do I need a separate PR to backport to 24.10?

That would be good, and please use git cherry-pick -x <commit hash on master branch> to backport commits from master.

@APCCV
Copy link
Contributor Author

APCCV commented Feb 3, 2025

That would be good, and please use git cherry-pick -x <commit hash on master branch> to backport commits from master.

Done.
Thank you for all your help with these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1715173329 1715173329 1715173329 approved these changes

@BKPepe BKPepe Awaiting requested review from BKPepe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@APCCV @1715173329 @BKPepe