lxc: add missing deps #25719
Merged
lxc: add missing deps #25719
+38
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graysky2
added a commit
to graysky2/openwrt
that referenced
this pull request
Jan 10, 2025
These four symbols are needed to satisfy lxc dependencies. Note - this needs to be merged before openwrt/packages#25719 Signed-off-by: John Audia <[email protected]>
graysky2
force-pushed
the
lxc-missing
branch
2 times, most recently
from
d30a6d2 to
9873c93
Compare
1715173329
reviewed
Jan 10, 2025
graysky2
added a commit
to graysky2/openwrt
that referenced
this pull request
Jan 10, 2025
These four symbols are needed to satisfy lxc dependencies. Note - this needs to be merged before openwrt/packages#25719 Signed-off-by: John Audia <[email protected]>
graysky2
added a commit
to graysky2/openwrt
that referenced
this pull request
Jan 10, 2025
These symbols are needed to satisfy lxc dependencies. Note - this needs to be merged before openwrt/packages#25719 Signed-off-by: John Audia <[email protected]>
graysky2
added a commit
to graysky2/openwrt
that referenced
this pull request
Jan 12, 2025
These symbols are needed to satisfy lxc dependencies. Note - this needs to be merged before openwrt/packages#25719 Signed-off-by: John Audia <[email protected]>
graysky2
added a commit
to graysky2/openwrt
that referenced
this pull request
Jan 20, 2025
These symbols are needed to satisfy lxc dependencies. Note - this needs to be merged before openwrt/packages#25719 Signed-off-by: John Audia <[email protected]>
graysky2
force-pushed
the
lxc-missing
branch
2 times, most recently
from
71979b6 to
445ef22
Compare
hauke
pushed a commit
to graysky2/openwrt
that referenced
this pull request
Jan 20, 2025
These symbols are needed to satisfy lxc dependencies. Note - this needs to be merged before openwrt/packages#25719 Signed-off-by: John Audia <[email protected]> Link: openwrt#17553 Signed-off-by: Hauke Mehrtens <[email protected]>
We do not package lxc-net or lxcfs so remove the lines within lxc-checkconfig that looks forCONFIG_IP_NF_TARGET_MASQUERADE and CONFIG_IP6_NF_TARGET_MASQUERADE which, as far as I know, is the only part of lxc that needs them. Also remove the check for FUSE since we do not pakcage lxcfs. Without this commit, users will see these two as missing. Signed-off-by: John Audia <[email protected]>
graysky2
force-pushed
the
lxc-missing
branch
2 times, most recently
from
b25f665 to
fe78ce6
Compare
|
please bump PKG_RELEASE. |
Several deps are missing based the output of lxc-checkconfig shown below before this commit is applied. CONFIG_IP_NF_TARGET_MASQUERADE and CONFIG_IP6_NF_TARGET_MASQUERADE are only needed for lxc-net which we do not package. % lxc-checkconfig | grep missing Cgroup device: missing CONFIG_IP_NF_TARGET_MASQUERADE: missing CONFIG_IP6_NF_TARGET_MASQUERADE: missing CONFIG_NETFILTER_XT_TARGET_CHECKSUM: missing FUSE (for use with lxcfs): missing checkpoint restore: missing CONFIG_UNIX_DIAG: missing CONFIG_INET_DIAG: missing CONFIG_PACKET_DIAG: missing CONFIG_NETLINK_DIAG: missing Additionally, two new patches have been added which remove checks for options that OpenWrt currently does not package and can serve are false positives for missing items from our kernel config, namely: lxc-net and lxc-checkpoint After applying this commit, below is the output showing that the kernel config[1] should pass all tests for functionality: % CONFIG=config ./lxc-checkconfig LXC version 6.0.3 --- Namespaces --- Namespaces: enabled Utsname namespace: enabled Ipc namespace: enabled Pid namespace: enabled User namespace: enabled Network namespace: enabled Namespace limits: cgroup: 383849 ipc: 383849 mnt: 383849 net: 383849 pid: 383849 time: 383849 user: 383849 uts: 383849 --- Control groups --- Cgroups: enabled Cgroup namespace: enabled Cgroup v1 mount points: Cgroup v2 mount points: - /sys/fs/cgroup Cgroup device: enabled Cgroup sched: enabled Cgroup cpu account: enabled Cgroup memory controller: enabled Cgroup cpuset: enabled --- Misc --- Veth pair device: enabled, loaded Macvlan: enabled, not loaded Vlan: enabled, not loaded Bridges: enabled, loaded Advanced netfilter: enabled, loaded CONFIG_NETFILTER_XT_TARGET_CHECKSUM: enabled, not loaded CONFIG_NETFILTER_XT_MATCH_COMMENT: enabled, loaded --- Checkpoint/Restore --- checkpoint restore: missing CONFIG_FHANDLE: enabled CONFIG_EVENTFD: enabled CONFIG_EPOLL: enabled CONFIG_UNIX_DIAG: enabled CONFIG_INET_DIAG: enabled CONFIG_PACKET_DIAG: enabled CONFIG_NETLINK_DIAG: enabled File capabilities: enabled 1. Generated on 23-Feb-2025 running bcm27xx/bcm2712 on r28869+1 Signed-off-by: John Audia <[email protected]>
graysky2
force-pushed
the
lxc-missing
branch
from
fe78ce6 to
391a8e3
Compare
Done, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several deps are missing based the output of lxc-checkconfig shown below before this commit is applied.
CONFIG_IP_NF_TARGET_MASQUERADEandCONFIG_IP6_NF_TARGET_MASQUERADEare only needed forlxc-netwhich we do not package.Additionally, two new patches have been added which remove checks for options that OpenWrt currently does not package and can serve are false positives for missing items from our kernel config, namely:
lxc-net and lxc-checkpoint
After applying this commit, below is the output showing that the kernel
config[1] should pass all tests for functionality:
Maintainer: @ratkaj