prometheus-node-exporter-lua remove zero values #24016
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoctivagusObitus
force-pushed
the
feature_omit_zero_export
branch
from
6afa841 to
237bf36
Compare
depending on the configuration there may be multiple interfaces creating multiple time series always reporting 0 value. omiting them from the export saves resources. most notably cpu. - remove time series with value of zero - make 'omit_zero_values' configurable - formating accoding to shfmt and stylua Signed-off-by: Markus Hube <[email protected]>
NoctivagusObitus
force-pushed
the
feature_omit_zero_export
branch
from
237bf36 to
bb6ae04
Compare
|
@champtar may I kindly ask if you could have a look at this? I would be happy to change the pull request given you have concerns. |
|
@champtar has this any chance to be merged? Like to have this option too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depending on the configuration there may be multiple interfaces creating multiple time series always
reporting 0 value. omiting them from the export saves resources. most notably cpu.
Signed-off-by: Markus Hube [email protected]