atlas-sw-probe: improve key creation

[Ansuel]

• Exit start if a probe_key is not present
• Add create_key command to generate a private_key based on the provided username in the atlas config.

@ja-pa

Signed-off-by: Ansuel Smith [email protected]

[Ansuel]

Some context...

I tested the package and it works good...

Problem is that i notice that if the atlas-probe script is run without a key, by adding one and restarting the probe won't register.
I need to remove the data dir in /tmp and restart to actually start the probe registration. I fixed this by simply not start when there isn't a key.

I added a create_key function to facilitate all the things...
I still need to test if the dropbearkey function generate a correct private key. It does generate a binary private key so i don't know if it does work with atlas-probe scripts.

Anyway i can confirm that this package works in 2 different router. (both r7800 running openwrt)

[BKPepe]

Guys, don't forget to bump PKG_RELEASE.

[Ansuel]

I notice that the key is lost on sysupgrade... I'm testing my solution and I will add it to this pr

[Ansuel]

Ok I tested the changes... Now should be all correct. @ja-pa can you checkout the changes? What do you think about variable names? Any suggestions?

[Ansuel]

I notice that dropbear private key is not compatible... so I had to add the package dropbearconvert if dropbear is present (with openssl server, ssh-keygen should be available right?)

Anyway I tested now and the converted private key works correctly and the probe correctly registers.

[Ansuel]

@neheb i read some warning for the dropbearconvert bin... Do you think that can cause some security risk ?

[neheb]

What error?

[Ansuel]

All arguments must be specified
Usage: dropbearconvert <inputtype> <outputtype> <inputfile> <outputfile>

CAUTION: This program is for convenience only, and is not secure if used on
untrusted input files, ie it could allow arbitrary code execution.
All parameters must be specified in order.

The input and output types are one of:

Someone should be root to exec dropbearconvert soooo ?

[ja-pa]

LGTM. Thanks !

[BKPepe]

I am wondering if we want to ship this file together with the file as it seems we are supplying documentation. Well, there should be, I know, but in my view, I can copy&paste the documentation which I wrote together with @ja-pa and move it to OpenWrt's documentation.

[BKPepe]

However, we can solve it later. Let's dont delay merging this. :-)