Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes #703

Merged
merged 4 commits into from
Jun 26, 2020
Merged

Minor fixes #703

merged 4 commits into from
Jun 26, 2020

Conversation

birdsarah
Copy link
Contributor

Fixes #699 #697 and a README typo

@codecov
Copy link

codecov bot commented Jun 26, 2020

Codecov Report

Merging #703 into master will decrease coverage by 20.21%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #703       +/-   ##
===========================================
- Coverage   58.80%   38.58%   -20.22%     
===========================================
  Files          44       28       -16     
  Lines        4071     3071     -1000     
===========================================
- Hits         2394     1185     -1209     
- Misses       1677     1886      +209     
Impacted Files Coverage Δ
automation/DataAggregator/BaseAggregator.py 63.70% <ø> (ø)
test/test_crawl.py
test/utilities.py
test/test_js_instrument.py
test/test_webdriver_utils.py
test/test_simple_commands.py
test/openwpmtest.py
test/test_http_instrumentation.py
test/test_profile.py
test/test_callstack_instrument.py
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c678d6...01138af. Read the comment docs.

@birdsarah
Copy link
Contributor Author

This PR excludes the test folder from the coverage stats which accounts for the decrease in coverage with an "n/a" diff.

@birdsarah birdsarah requested review from englehardt and vringar and removed request for englehardt June 26, 2020 03:50
Copy link
Collaborator

@englehardt englehardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanups :)

@englehardt englehardt merged commit 37f69dd into master Jun 26, 2020
@englehardt englehardt deleted the minor_fixes branch August 3, 2020 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove canvas_recursion test page
2 participants