Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(audio_fingerprinting): trigger audio fingerprint with click #1025

Merged
merged 1 commit into from
Jan 19, 2023

Conversation

vringar
Copy link
Contributor

@vringar vringar commented Jan 18, 2023

This is required as AudioContext doesn't work without user interaction

…ction

This is required as AudioContext doesn't work without user interaction
@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2023

Codecov Report

Base: 52.56% // Head: 51.14% // Decreases project coverage by -1.42% ⚠️

Coverage data is based on head (c4f17a5) compared to base (e58748f).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1025      +/-   ##
==========================================
- Coverage   52.56%   51.14%   -1.42%     
==========================================
  Files          34       34              
  Lines        3394     3394              
==========================================
- Hits         1784     1736      -48     
- Misses       1610     1658      +48     
Impacted Files Coverage Δ
openwpm/commands/profile_commands.py 54.71% <0.00%> (-26.42%) ⬇️
openwpm/errors.py 80.95% <0.00%> (-19.05%) ⬇️
openwpm/command_sequence.py 89.23% <0.00%> (-4.62%) ⬇️
openwpm/browser_manager.py 70.60% <0.00%> (-4.28%) ⬇️
openwpm/utilities/platform_utils.py 73.11% <0.00%> (-3.23%) ⬇️
openwpm/deploy_browsers/deploy_firefox.py 21.95% <0.00%> (-2.44%) ⬇️
openwpm/commands/browser_commands.py 27.73% <0.00%> (-1.57%) ⬇️
openwpm/task_manager.py 79.11% <0.00%> (-0.45%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vringar vringar mentioned this pull request Jan 18, 2023
@englehardt
Copy link
Collaborator

Non-blocking: do you know if this is an AudioContext spec change where the API actually is gated behind user interaction, or whether there is simply a race condition here?

@vringar
Copy link
Contributor Author

vringar commented Jan 19, 2023

There was an error message in the console saying smt like Audio context is unavailable without user interaction. And with some googling I found people also reported the same for Chrome. So maybe audio fingerprinting is just dead now?

However even with the click it was slightly racy, that's why I put the sleep 5 after the click

@vringar vringar merged commit 3265f84 into master Jan 19, 2023
@vringar vringar deleted the audio_fingerprinting_test branch January 19, 2023 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants