Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Localstack is once again broken #755

Closed
vringar opened this issue Sep 29, 2020 · 3 comments · Fixed by #756
Closed

Localstack is once again broken #755

vringar opened this issue Sep 29, 2020 · 3 comments · Fixed by #756
Labels
bug needs-investigation

Comments

@vringar
Copy link
Contributor

vringar commented Sep 29, 2020

Localstack is crashing both in local as well as Travis tests with
'NoneType' is not subscriptable
because calling to get the list of all buckets returns None
The quick fix is to disable the tests for now and focus our efforts on landing the aggregator rewrite soon.
So we can use MemoryStructuredStorageProvider and MemoryParquetStorageProvider or LocalParquetStorageProvider instead of spinning up Localstack
@vringar
Copy link
Contributor Author

vringar commented Sep 29, 2020

This affects #750, #752, #753 and #754

@vringar
Copy link
Contributor Author

vringar commented Sep 29, 2020

I'll verify that the tests fail on master tomorrow and if that's the case I'll disable them until they are removed by #753

@vringar
Copy link
Contributor Author

vringar commented Sep 30, 2020

The tests started failing on branches at least 12 days ago, but only failed yesterday for the cron build on master, as you can see here

@vringar vringar mentioned this issue Sep 30, 2020
Merged
vringar pushed a commit that referenced this issue Sep 30, 2020
Disabling s3 tests (#756)
c2a7004 
This way we can get CI passing again.
Closes #755
Zaxeli pushed a commit to Zaxeli/OpenWPM that referenced this issue Aug 10, 2021
Disabling s3 tests (openwpm#756)
b88b9ec 
This way we can get CI passing again.
Closes openwpm#755
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug needs-investigation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disabled s3 tests openwpm/OpenWPM
1 participant
@vringar