Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling pop-ups lead to crash in FinalizeCommand #741

Open
bkrumnow opened this issue Sep 10, 2020 · 0 comments
Open

Disabling pop-ups lead to crash in FinalizeCommand #741

bkrumnow opened this issue Sep 10, 2020 · 0 comments

Comments

@bkrumnow
Copy link

bkrumnow commented Sep 10, 2020

When setting pop-up block to True, each browser instances crashes during the finalizeCommand. This can be repeated by adding fo.set_preference("dom.disable_open_during_load", True) in automation/DeployBrowsers/configure_firefox.py.

https://github.com/mozilla/OpenWPM/blob/41023a800a1990e0b4177e1e345bb419d3dac222/automation/DeployBrowsers/configure_firefox.py

BrowserManager       - INFO     - BROWSER 11: EXECUTING COMMAND: IntitializeCommand()
BrowserManager       - INFO     - BROWSER 11: EXECUTING COMMAND: GetCommand(http://www.example.com,3)
BrowserManager       - INFO     - BROWSER 11: EXECUTING COMMAND: FinalizeCommand(5)
BrowserManager       - ERROR    - BROWSER 11: WebDriverException while executing command
Traceback (most recent call last):
  File ".../OpenWPM-0.12.0/automation/BrowserManager.py", line 523, in BrowserManager
    command_executor.execute_command(
  File ".../OpenWPM-0.12.0/automation/Commands/command_executor.py", line 70, in execute_command
    browser_commands.finalize(
  File ".../OpenWPM-0.12.0/automation/Commands/browser_commands.py", line 351, in finalize
    tab_restart_browser(webdriver)
  File ".../OpenWPM-0.12.0/automation/Commands/browser_commands.py", line 104, in tab_restart_browser
    assert len(webdriver.window_handles) == 1
  File ".../opt/miniconda3/envs/openwpm/lib/python3.8/site-packages/selenium/webdriver/remote/webdriver.py", line 724, in window_handles
    return self.execute(Command.W3C_GET_WINDOW_HANDLES)['value']
  File ".../opt/miniconda3/envs/openwpm/lib/python3.8/site-packages/selenium/webdriver/remote/webdriver.py", line 321, in execute
    self.error_handler.check_response(response)
  File ".../opt/miniconda3/envs/openwpm/lib/python3.8/site-packages/selenium/webdriver/remote/errorhandler.py", line 242, in check_response
    raise exception_class(message, screen, stacktrace)
selenium.common.exceptions.InvalidSessionIdException: Message: Tried to run command without establishing a connection
vringar pushed a commit that referenced this issue Nov 10, 2020
vringar pushed a commit that referenced this issue Sep 21, 2022
vringar pushed a commit that referenced this issue Sep 5, 2023
vringar pushed a commit that referenced this issue Sep 25, 2023
vringar pushed a commit that referenced this issue Oct 22, 2023
vringar pushed a commit that referenced this issue Feb 7, 2024
vringar pushed a commit that referenced this issue Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants