[chores] Publish images to Docker Hub and README update #244 #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nemesifier
requested changes
Jul 1, 2022
pandafy
force-pushed
the
issues/244-container-registry
branch
from
bf8ec5c to
21a7e19
Compare
nemesifier
requested changes
Jul 4, 2022
| @@ -32,7 +24,28 @@ jobs: | |||
| run: | | |||
| echo "127.0.0.1 dashboard.openwisp.org api.openwisp.org" | sudo tee -a /etc/hosts | |||
|
|
|||
| - name: Build & Publish | |||
| run: make publish TAG=edge || (docker-compose logs && exit 1) | |||
| # echo "$DOCKER_HUB_TOKEN" | docker login --username "$DOCKER_HUB_USER" --password-stdin | |||
There was a problem hiding this comment.
Do we need to keep this line here or can we remove it?
There was a problem hiding this comment.
It shows the command line equivalent of the below action.
I think we should keep it.
There was a problem hiding this comment.
Suggested change
| # echo "$DOCKER_HUB_TOKEN" | docker login --username "$DOCKER_HUB_USER" --password-stdin | |
| # the following action is equivalent to: | |
| # echo "$DOCKER_HUB_TOKEN" | docker login --username "$DOCKER_HUB_USER" --password-stdin |
Let's make it explicit, what do you think?
nemesifier
requested changes
Jul 6, 2022
| @@ -32,7 +24,28 @@ jobs: | |||
| run: | | |||
| echo "127.0.0.1 dashboard.openwisp.org api.openwisp.org" | sudo tee -a /etc/hosts | |||
|
|
|||
| - name: Build & Publish | |||
| run: make publish TAG=edge || (docker-compose logs && exit 1) | |||
| # echo "$DOCKER_HUB_TOKEN" | docker login --username "$DOCKER_HUB_USER" --password-stdin | |||
There was a problem hiding this comment.
Suggested change
| # echo "$DOCKER_HUB_TOKEN" | docker login --username "$DOCKER_HUB_USER" --password-stdin | |
| # the following action is equivalent to: | |
| # echo "$DOCKER_HUB_TOKEN" | docker login --username "$DOCKER_HUB_USER" --password-stdin |
Let's make it explicit, what do you think?
nemesifier
approved these changes
Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #244