Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deps] Add support for django 3.2 and 4.0 #263 #266

Merged
merged 4 commits into from
Dec 9, 2021

Conversation

devkapilbansal
Copy link
Member

@devkapilbansal devkapilbansal commented Dec 8, 2021

This PR drops support for Python 3.6

Closes #263

@devkapilbansal devkapilbansal force-pushed the issues/263-support-for-django4 branch 2 times, most recently from 1f93581 to bb63a71 Compare December 8, 2021 20:35
@devkapilbansal devkapilbansal marked this pull request as draft December 8, 2021 20:45
@devkapilbansal devkapilbansal force-pushed the issues/263-support-for-django4 branch 2 times, most recently from e952588 to dde9441 Compare December 8, 2021 21:31
@devkapilbansal devkapilbansal force-pushed the issues/263-support-for-django4 branch from dde9441 to 6786285 Compare December 8, 2021 21:32
@devkapilbansal devkapilbansal marked this pull request as ready for review December 8, 2021 21:33
Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- python: 3.7
TOXENV: py37-django30-djangorestframework312
- python: 3.8
TOXENV: py38-django30-djangorestframework312
- python: 3.9
TOXENV: py39-django30-djangorestframework312
- python: 3.6
TOXENV: py36-django31-djangorestframework312
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this library is widely used, I think we can leave these old builds (this one and the one above) to maintain wide support to legacy versions.

@devkapilbansal devkapilbansal force-pushed the issues/263-support-for-django4 branch from c8cdaeb to 6668243 Compare December 9, 2021 14:46
@devkapilbansal devkapilbansal force-pushed the issues/263-support-for-django4 branch from 7d21114 to 94df839 Compare December 9, 2021 15:00
Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@nemesifier nemesifier merged commit 4b98823 into master Dec 9, 2021
@devkapilbansal devkapilbansal deleted the issues/263-support-for-django4 branch December 9, 2021 15:47
@stianjensen
Copy link

Will there be a new release soon, with this fix?

@devkapilbansal
Copy link
Member Author

Hi @stianjensen there should be a release soon once some more issues are fixed

@nemesifier
Copy link
Member

@stianjensen the release is out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[deps] Add support for Django 3.2 and Django 4.0
3 participants