Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] Fix postgresql connection #248

Merged
merged 1 commit into from
Dec 1, 2020
Merged

[ci] Fix postgresql connection #248

merged 1 commit into from
Dec 1, 2020

Conversation

atb00ker
Copy link
Member

No description provided.

@atb00ker atb00ker force-pushed the fix-travis-ci branch 5 times, most recently from 3768776 to 8ba868c Compare November 13, 2020 12:03
@auvipy auvipy self-requested a review November 13, 2020 12:05
@atb00ker atb00ker force-pushed the fix-travis-ci branch 7 times, most recently from 22c29f7 to d169a03 Compare November 13, 2020 12:55
atb00ker
atb00ker commented Nov 13, 2020
View reviewed changes
Copy link
Member Author

@atb00ker atb00ker left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@auvipy @nemesisdesign
Travis automatically installs postgresql 13, so we have two options:

  1. Keep using 12, we would need to uninstalled 13 then install 12 and set it up in before_script section.
  2. Move to postgresql 13

I have take option 2.
Let me know if option one would be preferred for some reason! 😄

@atb00ker atb00ker changed the title {WIP}[ci] Fix postgresql connection [ci] Fix postgresql connection Nov 13, 2020
@atb00ker atb00ker marked this pull request as ready for review November 13, 2020 13:05
auvipy
auvipy approved these changes Nov 13, 2020
View reviewed changes
Copy link
Collaborator

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am happy with pg 13

@hemache
Copy link

hemache commented Nov 13, 2020

I guess I should rollback my fix 0040739

@dhaval-mehta dhaval-mehta mentioned this pull request Nov 23, 2020
Merged
@atb00ker atb00ker mentioned this pull request Dec 1, 2020
Open
@nemesifier nemesifier merged commit 496d958 into openwisp:master Dec 1, 2020
@nemesifier
Copy link
Member

Thanks, sorry for the delayed merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nemesifier nemesifier nemesifier approved these changes

@auvipy auvipy auvipy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@atb00ker @hemache @nemesifier @auvipy