Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Add support for openwisp-firmware-upgrader #199

Closed
nemesifier opened this issue Aug 17, 2020 · 3 comments · Fixed by #221
Closed

[feature] Add support for openwisp-firmware-upgrader #199

nemesifier opened this issue Aug 17, 2020 · 3 comments · Fixed by #221
Assignees
Labels
feature-request Hacktoberfest Easy issues for attracting Hacktoberfest participants.

Comments

@nemesifier
Copy link
Member

We can install this module by default and enable its API, we can provide a variable to disable the module and another variable to disable only the API if needed.

@pandafy
Copy link
Member

pandafy commented Nov 15, 2020

@nemesisdesign I don't see a potential use for creating a dedicated variable for disabling just APIs. The users can simple enable or disable APIs using by setting OPENWISP_FIRMWARE_UPGRADER_API in openwisp2_extra_django_settings variable.

@nemesifier
Copy link
Member Author

@nemesisdesign I don't see a potential use for creating a dedicated variable for disabling just APIs. The users can simple enable or disable APIs using by setting OPENWISP_FIRMWARE_UPGRADER_API in openwisp2_extra_django_settings variable.

Agreed, what about a brief section for the firmware upgrader module in the README like we have for network topology?
In that section we could advise this (that API can be disabled this way, as well as setting other settings and link to the firmware upgrader settings).

@pandafy
Copy link
Member

pandafy commented Nov 16, 2020

I have added it in the PR 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Hacktoberfest Easy issues for attracting Hacktoberfest participants.
Projects
Archived in project
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants