Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add keyword list #307

Merged
merged 1 commit into from
Jun 10, 2019
Merged

add keyword list #307

merged 1 commit into from
Jun 10, 2019

Conversation

mlin
Copy link
Member

@mlin mlin commented Apr 5, 2019

Not exciting, but we need an explicit list of keywords that can't be used as identifiers, because they'd complicate language parsing or cause ambiguities/confusion.

Not included in this list, but debatable: default sep version

@patmagee
Copy link
Member

👍

@DavyCats
Copy link
Contributor

Look good to me, I'm just wondering whether this the best way to format this list. It seems like it would be easy to overlook an item in the list. Maybe ordering them alphabetically would be better?

@geoffjentry geoffjentry added the voting active Changes for which voting is active. label Apr 19, 2019
@pshapiro4broad
Copy link
Contributor

+1

3 similar comments
@orodeh
Copy link
Contributor

orodeh commented Apr 19, 2019

👍

@rhpvorderman
Copy link
Contributor

👍

@illusional
Copy link
Contributor

+1

@multimeric
Copy link

I think this would ideally be mentioned in the Whitespace, Strings, Identifiers, Constants section, because this is restricting the set of valid identifiers already listed there.

However, I'm not allowed to request changes, so this is a +1 so it at least gets into the spec.

@geoffjentry
Copy link
Member

This passes and is waiting for implementation

@TMiguelT and @mlin - if one of you would want to make a followup PR representings Michael's comments that'd be great

@geoffjentry geoffjentry added awaiting implementation Changes that are awaiting implementation. and removed voting active Changes for which voting is active. labels Apr 30, 2019
@cjllanwarne
Copy link
Contributor

Unless anyone disagrees, I think this can be merged as implemented - I don't think any existing engines run counter to this by accidentally allowing these values?

@geoffjentry geoffjentry removed the awaiting implementation Changes that are awaiting implementation. label Jun 10, 2019
@geoffjentry geoffjentry merged commit cc19de2 into master Jun 10, 2019
@geoffjentry geoffjentry deleted the mlin-keywords branch June 10, 2019 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants