-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add keyword list #307
add keyword list #307
Conversation
👍 |
Look good to me, I'm just wondering whether this the best way to format this list. It seems like it would be easy to overlook an item in the list. Maybe ordering them alphabetically would be better? |
+1 |
3 similar comments
👍 |
👍 |
+1 |
I think this would ideally be mentioned in the However, I'm not allowed to request changes, so this is a +1 so it at least gets into the spec. |
This passes and is @TMiguelT and @mlin - if one of you would want to make a followup PR representings Michael's comments that'd be great |
Unless anyone disagrees, I think this can be merged as implemented - I don't think any existing engines run counter to this by accidentally allowing these values? |
Not exciting, but we need an explicit list of keywords that can't be used as identifiers, because they'd complicate language parsing or cause ambiguities/confusion.
Not included in this list, but debatable:
default sep version