[Hermes Grammar] Implement string escapes for #247 #272
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Grammar changes required for #247
(except the part about WDL being a UTF-8 document)EDIT: the parser seems to accept UTF-8 encoded documents - hooray!Demonstrated in action in broadinstitute/cromwell#4427
\"
)wdl_unescape
functions to allow the (previously unimplemented?)\xAB
style andU000000AB
style escape sequences.escape
tokens to make the final strings.NB: a similar change would be required in the WDL 1.0 parser if we want to make the above fixes (since the same bugs are also present in the 1.0 grammar)