Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hermes Grammar] Implement string escapes for #247 #272

Merged
merged 1 commit into from
Dec 14, 2018

Conversation

cjllanwarne
Copy link
Contributor

@cjllanwarne cjllanwarne commented Nov 27, 2018

Grammar changes required for #247 (except the part about WDL being a UTF-8 document) EDIT: the parser seems to accept UTF-8 encoded documents - hooray!

Demonstrated in action in broadinstitute/cromwell#4427

  • Captures escape sequences properly (previously we were missing \")
  • Makes escape sequences a token type rather than silently converting them.
    • This should make highlighting and conversions easier.
    • It also meant I didn't need to mess around in the language-specific wdl_unescape functions to allow the (previously unimplemented?) \xAB style and U000000AB style escape sequences.
    • But engines will now need to process escape tokens to make the final strings.

NB: a similar change would be required in the WDL 1.0 parser if we want to make the above fixes (since the same bugs are also present in the 1.0 grammar)

@cjllanwarne cjllanwarne changed the title Implement string escapes in #247 [Hermes Grammar] Implement string escapes for #247 Nov 27, 2018
@geoffjentry geoffjentry merged commit 005db97 into openwdl:master Dec 14, 2018
@patmagee patmagee added this to the v2.0 milestone Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants