Remove local firebase plugin #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jamshale <[email protected]>
swcurran
approved these changes
Aug 12, 2024
|
Approved for merging pending your testing. Good stuff! |
|
I have confirmed the plugin is loaded and trying to send the request to firebase. I didn't setup everything with my own firebase account to actually get to notification but I'm confident the plugin is working as expected. It should still get tested out from dev and test before being promoted to prod. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be all it takes to remove the local plugin from this project in favor of the plugin from the official plugin repo. Used the latest plugin version 0.12.2, which is on python 3.9.
NOTE: I need to test this better but I can see the plugin getting loaded and initialized.