-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove ICv1, PPv1 #3252
base: main
Are you sure you want to change the base?
refactor: remove ICv1, PPv1 #3252
Conversation
I stewed on how best to handle the OOB invitation attachments for these v1 protocols when they're no longer in the core repo. I think the way I would approach this is:
|
|
Signed-off-by: Daniel Bluhm <[email protected]>
Signed-off-by: Daniel Bluhm <[email protected]>
ae8c5a6
to
1ae4429
Compare
Signed-off-by: Daniel Bluhm <[email protected]>
1ae4429
to
5c3d9a2
Compare
Signed-off-by: Daniel Bluhm <[email protected]>
I've rebased this PR on current main and resolved merge conflicts. My last comment about restoring the ability to attach v1 credential offers or presentation requests to OOB are still relevant. This would need to be done from the plugin side. I'll make sure my comment is present on the corresponding PR in acapy-plugins. I believe this is otherwise ready for review. cc @swcurran @jamshale edit: minus the test failures that I need to take care of 😄 |
This PR removes Issue Credential v1 and Present Proof v1.
This is a rough cut of these changes that will need to be further refined.
Notes on sharp edges to be added.
Change Notes
Issue Credential v1
To enable ICv1 to continue to exist as a plugin, the following changes are/were necessary:
Present Proof v1
To enable PPv1 to continue to exist as a plugin, the following changes are/were necessary: