-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor OTX Models #4241
base: develop
Are you sure you want to change the base?
Refactor OTX Models #4241
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the large refactor! I have one minor comment and one concern related to the anomaly models.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
Is MaskDINO model also deleted?
Can we separate cleaning PRs and refactoring PRs to avoid huge changesets which are hard to review?
I understand that there are a lot of changes. However, I decided to delete models, that we rejected and those which are not exposed to Geti. My changes with input size affected all the models and it is better to delete them at all rather than fixing them and tests. What has been deleted: YOLOV9, MaskDINO, HuggingFace models (we will move HuggingFace functionality to the separate engine) + CLI install (There was no need to delete this file in this PR, but if it is OK, I would not return it back) |
Unused models could have been deleted in advance, before the actual refactoring, like Ashwin did with a number of other models, or even tasks |
Agree, I will create a separate PR with deleting things and update this one after |
Cleaning PR: #4247 |
PR is updated and ready for review |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #4241 +/- ##
===========================================
+ Coverage 77.11% 80.43% +3.32%
===========================================
Files 308 269 -39
Lines 30571 24999 -5572
===========================================
- Hits 23576 20109 -3467
+ Misses 6995 4890 -2105
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary
How to test
Checklist
License
Feel free to contact the maintainers if that's a concern.