Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid loading of reader if it doesn't exist #758

Merged
merged 2 commits into from
Jun 4, 2020
Merged

Avoid loading of reader if it doesn't exist #758

merged 2 commits into from
Jun 4, 2020

Conversation

ilyachur
Copy link
Contributor

@ilyachur ilyachur commented Jun 4, 2020

No description provided.

@ilyachur ilyachur requested a review from a team June 4, 2020 04:11
@ilyachur ilyachur added this to the 2020.4 milestone Jun 4, 2020
@ilyachur ilyachur requested a review from ilya-lavrenov June 4, 2020 04:12
@ilya-lavrenov
Copy link
Contributor

what if customer just forgot to put readers for target machine?

@ilyachur
Copy link
Contributor Author

ilyachur commented Jun 4, 2020

what if customer just forgot to put readers for target machine?

In this case he just get an error that Unknown model format! Cannot read the model: xxx

@ilyachur
Copy link
Contributor Author

ilyachur commented Jun 4, 2020

I updated error messages for ReadNetwork functions.

@ilya-lavrenov ilya-lavrenov self-assigned this Jun 4, 2020
@ilya-lavrenov ilya-lavrenov added category: inference OpenVINO Runtime library - Inference category: IR FE OpenVINO IR v10 / v11 FrontEnd enhancement New feature or request labels Jun 4, 2020
@ilyachur
Copy link
Contributor Author

ilyachur commented Jun 4, 2020

Re-run validation.

@ilyachur ilyachur merged commit a705f0c into openvinotoolkit:master Jun 4, 2020
@ilyachur ilyachur deleted the feature/ichuraev/optional_readers branch June 4, 2020 18:21
@ilyachur ilyachur restored the feature/ichuraev/optional_readers branch June 4, 2020 18:21
@ilyachur ilyachur deleted the feature/ichuraev/optional_readers branch June 4, 2020 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilya-lavrenov ilya-lavrenov ilya-lavrenov approved these changes

Assignees

@ilya-lavrenov ilya-lavrenov

Labels
category: inference OpenVINO Runtime library - Inference category: IR FE OpenVINO IR v10 / v11 FrontEnd enhancement New feature or request
Projects
None yet
Milestone
2020.4
Development

Successfully merging this pull request may close these issues.
2 participants
@ilyachur @ilya-lavrenov