Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MO should support LRN k param with caffe model, rather than fixed to 1 #716

Merged
merged 2 commits into from
Jun 3, 2020

Conversation

wistal
Copy link
Contributor

@wistal wistal commented Jun 2, 2020

I found when mo convert caffe model, the k param of LRN layer was hardcoded to 1, which should read from prototxt.
for example:
layer {
name: "norm1"
type: "LRN"
bottom: "relu1"
top: "norm1"
lrn_param {
local_size: 5
k: 2.000000
alpha: 0.000500
beta: 0.750000
}
}
When convert to mo, k will be set to 1, correct value should keep to 2.
The issue seems only for mo caffe.

I fixed it by modify mo code lrn_ext.py, and verified using 2 modes, the conversion result is correct.

@wistal wistal requested a review from a team June 2, 2020 02:07
@yury-gorbachev
Copy link
Contributor

@lazarevevgeny can you help?

@lazarevevgeny
Copy link
Contributor

@yury-gorbachev, I have restarted the test pipeline since it failed due to timeout. Once it is passed I will merge the PR.

@lazarevevgeny
Copy link
Contributor

@wistal, please, pick up changes from master.

@lazarevevgeny lazarevevgeny merged commit 2bb7010 into openvinotoolkit:master Jun 3, 2020
@ilya-lavrenov ilya-lavrenov added the category: MO Model Optimizer label Jun 4, 2020
@ilya-lavrenov ilya-lavrenov added this to the 2020.4 milestone Jun 4, 2020
@ilya-lavrenov ilya-lavrenov added the bug Something isn't working label Jun 4, 2020
@AnastasiaKazantaeva AnastasiaKazantaeva added the ExternalPR External contributor label Jun 9, 2020
redradist pushed a commit to redradist/openvino that referenced this pull request Oct 6, 2023
* [NVIDIA] Enable clang format

* [NVIDIA] Format code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working category: MO Model Optimizer ExternalPR External contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants