-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not use ONNX reader if ONNX importer was disabled #683
Do not use ONNX reader if ONNX importer was disabled #683
Conversation
@ilyachur I still don't understand why PR that brings new library onnx reader passed the CI? |
@gladilov-gleb Because ONNX importer is included in default build. It means that this library always exists in CI. |
Thanks for clarification! Sounds interesting, we need to take a look at the situation from myriad plugin side to understand should we change our CI pipeline or not. |
@ilyachur Please add |
I think it won't work for your case. We try to find this library in runtime (as plugins). Please correct me if I am not right. |
Depends on their problems. @omaskovx what kind of error do you have? |
For our CI, this will work. I checked our CI with your branch, the current fix also breaks our CI because the library is still being searched. We need to build this library in our CI, then the problem will be fixed, and for this please add |
which is described in 32398 |
@ilyachur Well, how is the progress? |
No description provided.