Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MO fails generating IR from XLNET model due to a bug in the transformation ConvertGroupedStridedSlice #625

Merged
merged 6 commits into from
May 29, 2020
Merged

MO fails generating IR from XLNET model due to a bug in the transformation ConvertGroupedStridedSlice #625

merged 6 commits into from
May 29, 2020

Conversation

vgavrilo
Copy link
Contributor

MO fails generating IR from XLNET model due to a bug in the transformation ConvertGroupedStridedSlice

Ticket: CVS-32166

Code:

  • Comments
  • Code style (PEP8)
  • Transformation generates reshape-able IR: N/A because there is no new transformation
  • Transformation preserves node names: N/A because there is no new transformation

Validation:

  • Unit tests
  • Framework layer tests: N/A because there is no new layers
  • Transformation tests: N/A because there is no new transformation
  • e2e model test: N/A because there is no new model
  • MO IR Reader tests: N/A because there is no new model

Documentation:

  • Supported frameworks layers list: N/A because there is no new layers
  • Supported public models list: N/A because there is no new public model
  • New operations specification: N/A because no new operations were enabled in MO
  • Guide on how to convert the public model: N/A because there is no new public model
  • User guide update: N/A because there is no need to update common user guide

Other:

  • Sample/Demo application to infer the model: N/A since the model can be executed using existing classification sample

@vgavrilo
Small fix in the transformation ConvertGroupedStridedSlice. Now Varia…
096b1dd 
…dicSplit is generated only in the case when node has at least 2 output nodes.
@vgavrilo vgavrilo requested review from a team and lazarevevgeny May 27, 2020 07:13
@vgavrilo vgavrilo added the category: MO Model Optimizer label May 27, 2020
lazarevevgeny
lazarevevgeny suggested changes May 27, 2020
View reviewed changes
Copy link
Contributor

@lazarevevgeny lazarevevgeny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a unit test for that case.

@jane-intel jane-intel merged commit 3a24eb6 into openvinotoolkit:master May 29, 2020
azhogov pushed a commit to azhogov/openvino that referenced this pull request Jun 1, 2020
@vgavrilo
MO fails generating IR from XLNET model due to a bug in the transform…
2bcfd5b 
…ation ConvertGroupedStridedSlice (openvinotoolkit#625)

* Small fix in the transformation ConvertGroupedStridedSlice. Now VariadicSplit is generated only in the case when node has at least 2 output nodes.

* Added unittests for the case when there is only one StridedSlice.
@ilya-lavrenov ilya-lavrenov added the bug Something isn't working label Jun 4, 2020
@ilya-lavrenov ilya-lavrenov added this to the 2020.4 milestone Jun 4, 2020
redradist pushed a commit to redradist/openvino that referenced this pull request Oct 6, 2023
@nkogteva
[NVIDIA] Skip LoadNetworkToDefaultDeviceNoThrow test (openvinotoolkit…
ddb21db 
…#625)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lazarevevgeny lazarevevgeny lazarevevgeny approved these changes

@jane-intel jane-intel jane-intel approved these changes

Assignees

@lazarevevgeny lazarevevgeny

Labels
bug Something isn't working category: MO Model Optimizer
Projects
None yet
Milestone
2020.4
Development

Successfully merging this pull request may close these issues.
4 participants
@vgavrilo @lazarevevgeny @jane-intel @ilya-lavrenov