-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ MO Interpolate ] Fixing broken model reshape-ability #619
[ MO Interpolate ] Fixing broken model reshape-ability #619
Conversation
Leaving code review for @lazarevevgeny, I approve the concept of "smart reshape". We should think whether we need to call transformations of this kind in run-time transformation pipeline in nGraph and where the best palace to do that (it should be done before network reshape). @jane-intel, please formulate your thoughts about it in that ticket. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
review finished
69b5c12
to
6b794b2
Compare
6b794b2
to
22d4d1b
Compare
Description: Interpolate operation with hard-coded (constant)
target_spatial_shape
input usually prevents user from successful spatial reshape of the model. It is totally valid, but customer may not be able to change the original model, so we introduce two transformations for making Interpolate operation reshape-able:InterpolateConcat
-- is valid for all user scenarios and is enabled in MO by defaultInterpolateReshapeWA
-- is not valid in all possible cases, but as we observed on practice -- this transformation helps in 99.99% cases.Ticket: CVS-32096 -- there may be more
Code:
Validation:
Documentation:
Other: