Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IE CLDNN] Activation with fused quantize bug fix #613

Conversation

mzyczyns
Copy link
Contributor

This change:

  • fixes bug connected with quantization fusing to activation
  • adds scale and activation fusing support
  • adds corresponding tests

JIRA: 31506
Please review: @vparamuz @jhajducz @kdobros

@mzyczyns mzyczyns added the category: GPU OpenVINO GPU plugin label May 26, 2020
@mzyczyns mzyczyns requested review from a team as code owners May 26, 2020 17:34
@mzyczyns mzyczyns force-pushed the private/mzyczyns/activation_fusing_bug branch 2 times, most recently from 60bf160 to 3cc8609 Compare May 29, 2020 14:57
@vladimir-paramuzov
Copy link
Contributor

@mzyczyns Could you rebase please?
I merged a fix for activation some time ago that disabled opt kernel when X*Y % 4 != 0 and !fused_ops.empty() (activation_kernel_opt.cpp:85)

I assume that this case is fixed by your patch, so probably this condition should be removed.

@mzyczyns mzyczyns force-pushed the private/mzyczyns/activation_fusing_bug branch from 3cc8609 to 4fcf1d9 Compare June 2, 2020 14:15
@vladimir-paramuzov vladimir-paramuzov merged commit 3ea1657 into openvinotoolkit:master Jun 3, 2020
@ilya-lavrenov ilya-lavrenov added this to the 2020.4 milestone Jun 4, 2020
@ilya-lavrenov ilya-lavrenov added the bug Something isn't working label Jun 4, 2020
redradist pushed a commit to redradist/openvino that referenced this pull request Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working category: GPU OpenVINO GPU plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants