-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SplitConcatPairToInterpolate inserts Interpolate when input is 2D #596
Merged
lazarevevgeny
merged 13 commits into
openvinotoolkit:master
from
vgavrilo:vgavrilo/split+concat-pair-2d
May 28, 2020
Merged
SplitConcatPairToInterpolate inserts Interpolate when input is 2D #596
lazarevevgeny
merged 13 commits into
openvinotoolkit:master
from
vgavrilo:vgavrilo/split+concat-pair-2d
May 28, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atPairToInterpolate.
General question: |
jane-intel
requested changes
May 28, 2020
model-optimizer/extensions/middle/SplitConcatPairToInterpolate.py
Outdated
Show resolved
Hide resolved
As far as I understand, the reason was that IE supports only 4D or 5D tensors as inputs of Interpolate. Hence, for example, 2D input tensors of Interoolate are not supported. |
model-optimizer/extensions/middle/SplitConcatPairToInterpolate.py
Outdated
Show resolved
Hide resolved
model-optimizer/extensions/middle/SplitConcatPairToInterpolate.py
Outdated
Show resolved
Hide resolved
jane-intel
approved these changes
May 28, 2020
Please rebase -- closed-ci shows build failures. |
…ice layer in the transformation SplitConcatPairToInterpolate.
lazarevevgeny
approved these changes
May 28, 2020
azhogov
pushed a commit
to azhogov/openvino
that referenced
this pull request
Jun 1, 2020
…envinotoolkit#596) * SplitConcatPairToInterpolate transformation was moved to middle stage and is applied only for 4D and 5D inputs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The MO incorrectly replaces Split+Concat with Interpolate for the STN model. If the transformation is disabled then the IR is generated properly and it produces correct inference results on CPU
Ticket: CVS-32079
Code:
Validation:
Documentation:
Other: