Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SplitConcatPairToInterpolate inserts Interpolate when input is 2D #596

Merged

Conversation

vgavrilo
Copy link
Contributor

Description:

The MO incorrectly replaces Split+Concat with Interpolate for the STN model. If the transformation is disabled then the IR is generated properly and it produces correct inference results on CPU

Ticket: CVS-32079

Code:

  • Comments
  • Code style (PEP8)
  • Transformation generates reshape-able IR: Yes
  • Transformation preserves node names: N/A because there is no new transformation

Validation:

  • Unit tests
  • Framework layer tests: N/A because no new layers were enabled in MO
  • Transformation tests: N/A because there is no new transformations
  • e2e model test: N/A because there is no new model
  • MO IR Reader tests: N/A because there is no new model

Documentation:

  • Supported frameworks layers list: N/A because no new layers were enabled in MO
  • Supported public models list: N/A because there is no new public model
  • New operations specification: N/A because no new operations were enabled in MO
  • Guide on how to convert the public model: N/A because there is no new public model
  • User guide update: N/A because there is no need to update common user guide

Other:

  • Sample/Demo application to infer the model: N/A since the model can be executed using existing classification sample

@vgavrilo vgavrilo requested review from lazarevevgeny and a team May 26, 2020 10:57
@lazarevevgeny lazarevevgeny requested a review from jane-intel May 27, 2020 08:04
@jane-intel
Copy link
Contributor

jane-intel commented May 28, 2020

General question:
What was wrong? Ticket is not descriptive enough. We had troubles because Interpolate doesn't work for less than 4D cases?

@vgavrilo
Copy link
Contributor Author

As far as I understand, the reason was that IE supports only 4D or 5D tensors as inputs of Interpolate. Hence, for example, 2D input tensors of Interoolate are not supported.

@jane-intel
Copy link
Contributor

Please rebase -- closed-ci shows build failures.

…ice layer in the transformation SplitConcatPairToInterpolate.
@lazarevevgeny lazarevevgeny merged commit 33aca7d into openvinotoolkit:master May 28, 2020
azhogov pushed a commit to azhogov/openvino that referenced this pull request Jun 1, 2020
…envinotoolkit#596)

* SplitConcatPairToInterpolate transformation was moved to middle stage and is applied only for 4D and 5D inputs.
@ilya-lavrenov ilya-lavrenov added the category: MO Model Optimizer label Jun 4, 2020
@ilya-lavrenov ilya-lavrenov added this to the 2020.4 milestone Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: MO Model Optimizer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants