Fixed duplicate names appearance in graph after fuse mul transformation. #5842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popovaan
requested review from
a team,
jane-intel,
lazarevevgeny,
pavel-esir and
iimironov
and removed request for
a team
lazarevevgeny
suggested changes
May 27, 2021
model-optimizer/unit_tests/mo/middle/passes/fusing/fuse_linear_ops_test.py
Show resolved
Hide resolved
lazarevevgeny
approved these changes
May 28, 2021
yekruglov
pushed a commit
to yekruglov/openvino
that referenced
this pull request
Jun 7, 2021
…on. (openvinotoolkit#5842) * Added manual set of unique name to the data node. * Added attributes checks in unit test. * Removed redundant line break.
rnugmanx
pushed a commit
to rnugmanx/openvino
that referenced
this pull request
Aug 26, 2021
…on. (openvinotoolkit#5842) * Added manual set of unique name to the data node. * Added attributes checks in unit test. * Removed redundant line break.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root cause analysis:
_fuse_add transformation finds MatMul node and a Mul node that goes after it, than removes Mul node and inserts a new Mul node before the MatMul using set_source() method. set_source() copies attributes from the data node of old connection to the new data node and it leads to appearance of two data nodes with the same name.
After the constant folding and graph cleanup the operation that goes to the new data node is deleted as const producer and the new Const op is created with the name obtained from data node which leads to the error, that graph contains two nodes with the same name.
Solution:
Manually set unique name to the new data node.
Ticket: 54845
Code:
Validation:
Documentation: