Add proper signal_size handling for reference nGraph implementation for operations DFT and IDFT #5610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…signal_size-handling
…signal_size-handling
…signal_size-handling
…signal_size-handling
…signal_size-handling
…signal_size-handling
…signal_size-handling
…signal_size-handling
vgavrilo
requested review from
a team,
pavel-esir and
yekruglov
and removed request for
a team
|
@ilyachur, @lazarevevgeny, please, see this PR (#5610). |
3 similar comments
|
@ilyachur, @lazarevevgeny, please, see this PR (#5610). |
|
@ilyachur, @lazarevevgeny, please, see this PR (#5610). |
|
@ilyachur, @lazarevevgeny, please, see this PR (#5610). |
ilyachur
reviewed
May 19, 2021
|
I will not review these changes. So I removed myself from the reviewers list. |
ilyachur
reviewed
May 19, 2021
apertovs
suggested changes
May 19, 2021
inference-engine/tests/functional/plugin/cpu/shared_tests_instances/skip_tests_config.cpp
Outdated
Show resolved
Hide resolved
apertovs
approved these changes
May 19, 2021
ilyachur
approved these changes
May 20, 2021
yekruglov
pushed a commit
to yekruglov/openvino
that referenced
this pull request
Jun 7, 2021
…or operations DFT and IDFT (openvinotoolkit#5610) * Added tests for 2D DFT when we have signal_size and axes [0, 2]. * Rewritten reference implementation of DFT and IDFT. * Code style fixes. * Reverted changes. * Added debug prints. * Temporarily commented some functions. * Reverted changes in (I)DFT reference. * Added more debug prints (in evaluates_map.cpp, to evaluate() for IDFT). * Added setting output shape for DFT and IDFT evaluate() in evaluates_map.cpp. * Added more tests for signal_size case of DFT. * Written tests for signal_size case of IDFT. * Deleted debug prints from (I)DFT reference implementation (the file fft.cpp). * Deleted debug prints from evaluate() for DFT and IDFT. * Deleted debug prints from tests for DFT. * Deleted debug prints from IDFT tests. * Code style fixes. * Enabled CPU evaluation tests for DFT and IDFT in CPU supported cases. * Enabled CPU (I)DFT layer tests. * Copied fix for specialization of function is_float() for (b)float16 from Pertovsky Aleksandr's PR 5654. * Reverted changes in the function is_float() from ie_precision.h. * Disabled BF16 CPU FuncTests for (I)DFT. * Deleted filling 'buffer' by zeros. Simplified the function lengths_except_given_axis. * Small fix. * Code style fix. * Reverted deleting 'std::fill(buffer.begin(), buffer.end(), complex_type{0.0f, 0.0f});' * Reverted changes in the function lengths_except_given_axis(). * Changes in the function lengths_except_given_axis(). * Small fix. * Deleted commented code. * Simplifications in the function lengths_except_given_axis(). * Deleted commented code. * Enabled BF16 (I)DFT CPU FuncTests. * Fixed comments before disabled (I)DFT IE_CPU tests.
rnugmanx
pushed a commit
to rnugmanx/openvino
that referenced
this pull request
Aug 26, 2021
…or operations DFT and IDFT (openvinotoolkit#5610) * Added tests for 2D DFT when we have signal_size and axes [0, 2]. * Rewritten reference implementation of DFT and IDFT. * Code style fixes. * Reverted changes. * Added debug prints. * Temporarily commented some functions. * Reverted changes in (I)DFT reference. * Added more debug prints (in evaluates_map.cpp, to evaluate() for IDFT). * Added setting output shape for DFT and IDFT evaluate() in evaluates_map.cpp. * Added more tests for signal_size case of DFT. * Written tests for signal_size case of IDFT. * Deleted debug prints from (I)DFT reference implementation (the file fft.cpp). * Deleted debug prints from evaluate() for DFT and IDFT. * Deleted debug prints from tests for DFT. * Deleted debug prints from IDFT tests. * Code style fixes. * Enabled CPU evaluation tests for DFT and IDFT in CPU supported cases. * Enabled CPU (I)DFT layer tests. * Copied fix for specialization of function is_float() for (b)float16 from Pertovsky Aleksandr's PR 5654. * Reverted changes in the function is_float() from ie_precision.h. * Disabled BF16 CPU FuncTests for (I)DFT. * Deleted filling 'buffer' by zeros. Simplified the function lengths_except_given_axis. * Small fix. * Code style fix. * Reverted deleting 'std::fill(buffer.begin(), buffer.end(), complex_type{0.0f, 0.0f});' * Reverted changes in the function lengths_except_given_axis(). * Changes in the function lengths_except_given_axis(). * Small fix. * Deleted commented code. * Simplifications in the function lengths_except_given_axis(). * Deleted commented code. * Enabled BF16 (I)DFT CPU FuncTests. * Fixed comments before disabled (I)DFT IE_CPU tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Tickets: