Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Speech sample] Added numpy array support #5479

Merged
merged 7 commits into from
Jun 3, 2021
Merged

[Speech sample] Added numpy array support #5479

merged 7 commits into from
Jun 3, 2021

Conversation

antonrom23
Copy link

@antonrom23 antonrom23 commented Apr 30, 2021 •
edited
Loading

Details:

  • Added support npz files in C++ speech sample: in these changes user can use npz format for input and reference files, and also save results in output npz file. Sample continue support input file in ark format.
  • Added thirdparty library cnpy to save and load npz files. It is depends on zlib library.
  • Added thirdparty library zlib to support compressed input npz files and use CRC32 methods in cnpy library.

Tickets:

  • 54188

@dorloff dorloff requested review from mryzhov and elilobanova April 30, 2021 13:51
@antonrom23 antonrom23 force-pushed the antonrom/feature/speech_sample_numpy_support branch 4 times, most recently from 6315144 to 62832b4 Compare May 17, 2021 15:54
@antonrom23 antonrom23 requested a review from ilya-lavrenov May 18, 2021 13:43
@antonrom23 antonrom23 marked this pull request as ready for review May 18, 2021 13:43
@antonrom23 antonrom23 requested a review from a team as a code owner May 18, 2021 13:43
@antonrom23 antonrom23 requested a review from a team May 18, 2021 13:43
@antonrom23 antonrom23 force-pushed the antonrom/feature/speech_sample_numpy_support branch 2 times, most recently from 5fd7058 to dcf9737 Compare May 19, 2021 17:27
@ilya-lavrenov ilya-lavrenov mentioned this pull request May 21, 2021
Merged
@antonrom23 antonrom23 force-pushed the antonrom/feature/speech_sample_numpy_support branch from dcf9737 to f795987 Compare May 21, 2021 10:01
mryzhov
mryzhov reviewed May 24, 2021
View reviewed changes
Copy link
Contributor

@mryzhov mryzhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The generic question.
What is the reason to include cnpy and zlib sources directly to the repository?

mryzhov
mryzhov reviewed May 24, 2021
View reviewed changes
Copy link
Contributor

@mryzhov mryzhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please also provide the link to the MR for the tests in thois PR

@mryzhov mryzhov requested a review from dmitriikhurtin May 24, 2021 11:24
@antonrom23 antonrom23 force-pushed the antonrom/feature/speech_sample_numpy_support branch from f795987 to 474f226 Compare May 30, 2021 14:18
@antonrom23 antonrom23 requested a review from a team May 30, 2021 14:18
@antonrom23 antonrom23 force-pushed the antonrom/feature/speech_sample_numpy_support branch from 970f43b to 1f6255e Compare May 31, 2021 06:16
ilya-lavrenov
ilya-lavrenov reviewed May 31, 2021
View reviewed changes
@antonrom23 antonrom23 force-pushed the antonrom/feature/speech_sample_numpy_support branch from 1f6255e to ec95383 Compare June 1, 2021 05:46
@ilya-lavrenov ilya-lavrenov added this to the 2021.4 milestone Jun 1, 2021
@ilya-lavrenov ilya-lavrenov added the category: samples OpenVINO Runtime Samples label Jun 1, 2021
@antonrom23 antonrom23 force-pushed the antonrom/feature/speech_sample_numpy_support branch from d8e5768 to 488863b Compare June 2, 2021 09:35
@antonrom23 antonrom23 force-pushed the antonrom/feature/speech_sample_numpy_support branch from 488863b to 7e32ca4 Compare June 3, 2021 04:03
@antonrom23
Copy link
Author

internal tests: PR #977, internal test pipeline passed: PR #1789

@ilya-lavrenov ilya-lavrenov merged commit 63a335f into openvinotoolkit:master Jun 3, 2021
yekruglov pushed a commit to yekruglov/openvino that referenced this pull request Jun 7, 2021
@yekruglov
[Speech sample] Added numpy array support (openvinotoolkit#5479)
5a52280 
* [Speech sample] Added numpy array support

* Added zlib library submodule to thirdparty

* Added cnpy library original version

* Changed cnpy library: some methods and fixed Klocwork issues

* Change cmakelists and documentation

* Added license information in TPP

* Added support make install to thirdparty components
rnugmanx pushed a commit to rnugmanx/openvino that referenced this pull request Aug 26, 2021
[Speech sample] Added numpy array support (openvinotoolkit#5479)
6f5acb2 
* [Speech sample] Added numpy array support

* Added zlib library submodule to thirdparty

* Added cnpy library original version

* Changed cnpy library: some methods and fixed Klocwork issues

* Change cmakelists and documentation

* Added license information in TPP

* Added support make install to thirdparty components
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mryzhov mryzhov mryzhov left review comments

@ilya-lavrenov ilya-lavrenov ilya-lavrenov approved these changes

@generalova-kate generalova-kate generalova-kate approved these changes

@dorloff dorloff Awaiting requested review from dorloff

@elilobanova elilobanova Awaiting requested review from elilobanova

@dmitriikhurtin dmitriikhurtin Awaiting requested review from dmitriikhurtin

Assignees
No one assigned
Labels
category: samples OpenVINO Runtime Samples
Projects
None yet
Milestone
2021.4
Development

Successfully merging this pull request may close these issues.
4 participants
@antonrom23 @ilya-lavrenov @generalova-kate @mryzhov