Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PT FE] Return default NonZero type where possible #29072

Merged
merged 2 commits into from
Feb 20, 2025
Merged

[PT FE] Return default NonZero type where possible #29072

merged 2 commits into from
Feb 20, 2025

Conversation

mvafin
Copy link
Contributor

@mvafin mvafin commented Feb 19, 2025

Details:

  • Return default NonZero type where possible. This allows to merge two NonZero nodes.

Tickets:

@mvafin mvafin requested a review from eaidova February 19, 2025 14:48
@mvafin mvafin requested a review from a team as a code owner February 19, 2025 14:48
@mvafin mvafin requested a review from cavusmustafa February 19, 2025 14:48
@github-actions github-actions bot added the category: PyTorch FE OpenVINO PyTorch Frontend label Feb 19, 2025
rkazants
rkazants approved these changes Feb 19, 2025
View reviewed changes
Copy link
Member

@rkazants rkazants left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like a workaround. i32 can be a bit optimal since no need to use internal convert ops for plugins not supporting i64.

better to fix it on transformation side.

@mvafin mvafin added this pull request to the merge queue Feb 20, 2025
Merged via the queue into openvinotoolkit:master with commit 61ab2ef Feb 20, 2025
182 checks passed
@mvafin mvafin deleted the mvafin/pt_fe/nonzero_def branch February 20, 2025 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eaidova eaidova eaidova approved these changes

@rkazants rkazants rkazants approved these changes

@cavusmustafa cavusmustafa Awaiting requested review from cavusmustafa cavusmustafa is a code owner automatically assigned from openvinotoolkit/openvino-pytorch-frontend-maintainers

Assignees
No one assigned
Labels
category: PyTorch FE OpenVINO PyTorch Frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mvafin @eaidova @rkazants