Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring of SpecialStageProcessor #2885

Merged
merged 2 commits into from
Nov 17, 2020
Merged

Refactoring of SpecialStageProcessor #2885

merged 2 commits into from
Nov 17, 2020

Conversation

rvyunov
Copy link
Contributor

@rvyunov rvyunov commented Oct 29, 2020 •
edited
Loading

#-36628
#-39079

  • Refactoring of SpecialStageProcessor class implementation
  • Fix to support pytorch-yolo-v3
  • Test related with supporting of pytorch-yolo-v3

@rvyunov rvyunov added category: IE Tests OpenVINO Test: plugins and common category: VPU labels Oct 29, 2020
@rvyunov rvyunov added this to the 2021.2 milestone Oct 29, 2020
@rvyunov rvyunov self-assigned this Oct 29, 2020
@rvyunov rvyunov force-pushed the vpu/rvyunov/reshape_refactoring branch 2 times, most recently from 87013c1 to 8bfafd8 Compare November 4, 2020 20:02
@rvyunov rvyunov requested review from andrejsokolov and a user November 4, 2020 20:11
@rvyunov rvyunov marked this pull request as ready for review November 4, 2020 20:13
@rvyunov rvyunov requested a review from a team November 4, 2020 20:13
@rvyunov rvyunov requested a review from a team as a code owner November 4, 2020 20:13
@rvyunov rvyunov force-pushed the vpu/rvyunov/reshape_refactoring branch from 8bfafd8 to 9c9eef6 Compare November 4, 2020 23:31
ggladilov
ggladilov reviewed Nov 9, 2020
View reviewed changes
Copy link
Contributor

@ggladilov ggladilov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure it's a good idea to put refactoring and fix at the same PR
BTW, there is no explanation about which part of changes is actually the fix

inference-engine/src/vpu/graph_transformer/src/middleend/special_stage_processor.cpp Outdated Show resolved Hide resolved
inference-engine/src/vpu/graph_transformer/src/middleend/special_stage_processor.cpp Show resolved Hide resolved
inference-engine/src/vpu/graph_transformer/src/middleend/special_stage_processor.cpp Outdated Show resolved Hide resolved
inference-engine/src/vpu/graph_transformer/src/middleend/special_stage_processor.cpp Outdated Show resolved Hide resolved
inference-engine/src/vpu/graph_transformer/src/middleend/special_stage_processor.cpp Outdated Show resolved Hide resolved
inference-engine/src/vpu/graph_transformer/src/middleend/special_stage_processor.cpp Outdated Show resolved Hide resolved
inference-engine/src/vpu/graph_transformer/src/middleend/special_stage_processor.cpp Outdated Show resolved Hide resolved
inference-engine/tests/functional/plugin/myriad/subgraph_tests/concat_split_transpose.cpp Show resolved Hide resolved
inference-engine/tests/functional/plugin/myriad/subgraph_tests/concat_split_transpose.cpp Show resolved Hide resolved
@jgespino jgespino mentioned this pull request Nov 9, 2020
Closed
@rvyunov
Copy link
Contributor Author

rvyunov commented Nov 9, 2020

I'm not sure it's a good idea to put refactoring and fix at the same PR
BTW, there is no explanation about which part of changes is actually the fix

Are you OK if I move fix to separate commit?

@rvyunov rvyunov force-pushed the vpu/rvyunov/reshape_refactoring branch from 9c9eef6 to 4ac682a Compare November 16, 2020 20:53
@rvyunov
Copy link
Contributor Author

rvyunov commented Nov 16, 2020

@andrejsokolov , @gladilov-gleb , could you take a look once again, please?

@rvyunov rvyunov force-pushed the vpu/rvyunov/reshape_refactoring branch from 4ac682a to b3bb6a9 Compare November 17, 2020 06:54
@andrejsokolov andrejsokolov self-requested a review November 17, 2020 08:19
@rvyunov
Copy link
Contributor Author

rvyunov commented Nov 17, 2020

@Maxim-Doronin , could you merge it please?

@Maxim-Doronin
Copy link
Contributor

@Maxim-Doronin , could you merge it please?

I can't see any completed DL-Benchmark job. I'd wait for it

@Maxim-Doronin Maxim-Doronin merged commit 5bc74aa into openvinotoolkit:master Nov 17, 2020
mryzhov pushed a commit to mryzhov/openvino that referenced this pull request Dec 16, 2020
@rvyunov @mryzhov
[IE][VPU]: Refactoring of SpecialStageProcessor (openvinotoolkit#2885)
8bd2293 
* SpecialStageProcessor refactoring
* Fix for Yolo-v3-pytorch and related test
mryzhov pushed a commit to mryzhov/openvino that referenced this pull request Jan 14, 2021
@rvyunov @mryzhov
[IE][VPU]: Refactoring of SpecialStageProcessor (openvinotoolkit#2885)
7c4d158 
* SpecialStageProcessor refactoring
* Fix for Yolo-v3-pytorch and related test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggladilov ggladilov ggladilov approved these changes

@andrejsokolov andrejsokolov andrejsokolov approved these changes

Assignees

@rvyunov rvyunov

Labels
category: IE Tests OpenVINO Test: plugins and common
Projects
None yet
Milestone
2021.2
Development

Successfully merging this pull request may close these issues.
4 participants
@rvyunov @Maxim-Doronin @ggladilov @andrejsokolov