Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Py OV] Update samples to use __version__ instead of get_version() #28717

Merged
merged 2 commits into from
Jan 29, 2025

Conversation

almilosz
Copy link
Contributor

Details:

  • Change get_version() to __version__
  • Discussed here

Tickets:

Signed-off-by: Alicja Miloszewska <[email protected]>
@almilosz almilosz requested review from a team as code owners January 28, 2025 13:22
@almilosz almilosz requested review from kblaszczak-intel and removed request for a team January 28, 2025 13:22
@github-actions github-actions bot added category: samples OpenVINO Runtime Samples category: docs OpenVINO documentation labels Jan 28, 2025
@@ -21,7 +21,7 @@ The following Python API is used in the application:

| Feature | API | Description |
| --------------------------| ------------------------------------------------|----------------------------------------------|
| OpenVINO Runtime Version | [openvino.runtime.get_version] | Get Openvino API version. |
| OpenVINO API Version | [openvino.__version__] | Get Openvino API version. |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| OpenVINO API Version | [openvino.__version__] | Get Openvino API version. |
| OpenVINO API Version | [openvino.__version__] | Get Openvino API version. |

Copy link
Contributor

@akuporos akuporos Jan 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please remove unnecessary spaces in all files

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we also need to avoid runtime namespace below

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rkazants generally yes, but there is a task for doc team to update all doc files :)

@akuporos akuporos added this to the 2025.1 milestone Jan 28, 2025
Signed-off-by: Alicja Miloszewska <[email protected]>
@almilosz almilosz added this pull request to the merge queue Jan 29, 2025
Merged via the queue into openvinotoolkit:master with commit d64c8d4 Jan 29, 2025
186 checks passed
@almilosz almilosz deleted the almilosz/update-get-version branch January 29, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: docs OpenVINO documentation category: samples OpenVINO Runtime Samples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants